Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 19799003: [android] Instumentation tests determine whether to install test apk based on Md5Sum. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unnecessary import Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/instrumentation/setup.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/test_runner.py
diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py
index dcf3d20613d6e5b867688d5c83d0c492da6f8554..b4ad7f44ddf20449c1fc2dc06e3a89d5e86ca799 100644
--- a/build/android/pylib/instrumentation/test_runner.py
+++ b/build/android/pylib/instrumentation/test_runner.py
@@ -52,16 +52,15 @@ class TestRunner(base_test_runner.BaseTestRunner):
'/chrome-profile*')
_DEVICE_HAS_TEST_FILES = {}
- def __init__(self, build_type, test_data, install_apk, save_perf_json,
- screenshot_failures, tool, wait_for_debugger, disable_assertions,
- push_deps, cleanup_test_files, device, shard_index, test_pkg,
+ def __init__(self, build_type, test_data, save_perf_json, screenshot_failures,
+ tool, wait_for_debugger, disable_assertions, push_deps,
+ cleanup_test_files, device, shard_index, test_pkg,
ports_to_forward):
"""Create a new TestRunner.
Args:
build_type: 'Release' or 'Debug'.
test_data: Location of the test data.
- install_apk: Re-installs the apk if opted.
save_perf_json: Whether or not to save the JSON file from UI perf tests.
screenshot_failures: Take a screenshot for a test failure
tool: Name of the Valgrind tool.
@@ -87,12 +86,10 @@ class TestRunner(base_test_runner.BaseTestRunner):
self.disable_assertions = disable_assertions
self.test_pkg = test_pkg
self.ports_to_forward = ports_to_forward
- self.install_apk = install_apk
#override
def InstallTestPackage(self):
- if self.install_apk:
- self.test_pkg.Install(self.adb)
+ self.test_pkg.Install(self.adb)
#override
def PushDataDeps(self):
« no previous file with comments | « build/android/pylib/instrumentation/setup.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698