Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 19799003: [android] Instumentation tests determine whether to install test apk based on Md5Sum. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unnecessary import Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/android_commands.py ('k') | build/android/pylib/host_driven/python_test_base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/test_package_apk.py
diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py
index 27dad352b6cf57fcb652e918e995947592453e95..1ea0f8892451f6d5f3d0d84acc8f3bda26adce8d 100644
--- a/build/android/pylib/gtest/test_package_apk.py
+++ b/build/android/pylib/gtest/test_package_apk.py
@@ -88,15 +88,6 @@ class TestPackageApk(TestPackage):
action='android.intent.action.MAIN',
force_stop=True)
- def _NeedsInstall(self):
- installed_apk_path = self.adb.GetApplicationPath(
- self._test_apk_package_name)
- if installed_apk_path:
- return not self.adb.CheckMd5Sum(
- self.suite_path_full, installed_apk_path, ignore_paths=True)
- else:
- return True
-
def _GetTestSuiteBaseName(self):
"""Returns the base name of the test suite."""
# APK test suite names end with '-debug.apk'
@@ -143,8 +134,6 @@ class TestPackageApk(TestPackage):
#override
def Install(self):
self.tool.CopyFiles()
- if self._NeedsInstall():
- # Always uninstall the previous one (by activity name); we don't
- # know what was embedded in it.
- self.adb.ManagedInstall(self.suite_path_full, False,
- package_name=self._test_apk_package_name)
+ self.adb.ManagedInstall(self.suite_path_full, False,
+ package_name=self._test_apk_package_name)
+
« no previous file with comments | « build/android/pylib/android_commands.py ('k') | build/android/pylib/host_driven/python_test_base.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698