Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 19798005: Fix issues showing GPU memory in task manager. (Closed)

Created:
7 years, 5 months ago by ccameron
Modified:
7 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Fix issues showing GPU memory in task manager. Don't put GPU process usage (the total over all processes) in parens because people thought this meant it was negative. Rather, put an asterisk next to it. Also, if multiple tabs are sharing a process, only show the memory usage for the group once. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/task_manager/task_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
Small tweak to GPU memory reporting.
7 years, 5 months ago (2013-07-24 00:00:49 UTC) #1
yoshiki
lgtm
7 years, 5 months ago (2013-07-24 02:25:16 UTC) #2
ccameron
Thanks!!
7 years, 5 months ago (2013-07-24 02:27:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/19798005/1
7 years, 5 months ago (2013-07-24 02:27:37 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 04:55:24 UTC) #5
Message was sent while issue was closed.
Change committed as 213342

Powered by Google App Engine
This is Rietveld 408576698