Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 19790011: Fix a defect on a test runner for ppapi tests (Closed)

Created:
7 years, 5 months ago by yhirano
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

ThreadedTestRunner::Run contained a PP_DCHECK with a side effect. Some tests failed because of it. This CL fixes the problem. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213386

Patch Set 1 #

Patch Set 2 : Fix a build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ppapi/tests/test_case.h View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
yhirano
7 years, 5 months ago (2013-07-22 12:19:11 UTC) #1
dmichael (off chromium)
Oops, thanks! lgtm
7 years, 5 months ago (2013-07-22 16:15:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/19790011/1
7 years, 5 months ago (2013-07-23 01:02:59 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-23 01:45:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/19790011/20001
7 years, 5 months ago (2013-07-23 01:45:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=150908
7 years, 5 months ago (2013-07-23 03:08:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/19790011/20001
7 years, 5 months ago (2013-07-23 03:48:36 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=150969
7 years, 5 months ago (2013-07-23 04:27:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/19790011/20001
7 years, 5 months ago (2013-07-24 03:33:12 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 10:15:07 UTC) #10
Message was sent while issue was closed.
Change committed as 213386

Powered by Google App Engine
This is Rietveld 408576698