Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19788004: Implement server-side confirm request for privet registration (Closed)

Created:
7 years, 5 months ago by Noam Samuel
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement server-side confirm request for privet registration This implements the confirm request side of privet registration that sends an authenticated request to the cloud print server to claim the device. BUG=245375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213277

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -2 lines) Patch
A chrome/browser/local_discovery/privet_confirm_api_flow.h View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/privet_confirm_api_flow.cc View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_constants.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/cloud_print/cloud_print_constants.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Noam Samuel
7 years, 5 months ago (2013-07-19 22:09:39 UTC) #1
gene
lgtm
7 years, 5 months ago (2013-07-22 10:32:39 UTC) #2
gene
lgtm https://codereview.chromium.org/19788004/diff/1/chrome/browser/local_discovery/privet_confirm_api_flow.h File chrome/browser/local_discovery/privet_confirm_api_flow.h (right): https://codereview.chromium.org/19788004/diff/1/chrome/browser/local_discovery/privet_confirm_api_flow.h#newcode32 chrome/browser/local_discovery/privet_confirm_api_flow.h:32: ResponseCallback; fit on one line
7 years, 5 months ago (2013-07-22 10:32:50 UTC) #3
Noam Samuel
https://codereview.chromium.org/19788004/diff/1/chrome/browser/local_discovery/privet_confirm_api_flow.h File chrome/browser/local_discovery/privet_confirm_api_flow.h (right): https://codereview.chromium.org/19788004/diff/1/chrome/browser/local_discovery/privet_confirm_api_flow.h#newcode32 chrome/browser/local_discovery/privet_confirm_api_flow.h:32: ResponseCallback; On 2013/07/22 10:32:50, gene wrote: > fit on ...
7 years, 5 months ago (2013-07-22 19:22:05 UTC) #4
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/19788004/diff/6001/chrome/browser/local_discovery/privet_confirm_api_flow.cc File chrome/browser/local_discovery/privet_confirm_api_flow.cc (right): https://codereview.chromium.org/19788004/diff/6001/chrome/browser/local_discovery/privet_confirm_api_flow.cc#newcode88 chrome/browser/local_discovery/privet_confirm_api_flow.cc:88: bool success; unitialized var https://codereview.chromium.org/19788004/diff/6001/chrome/browser/local_discovery/privet_confirm_api_flow.h File chrome/browser/local_discovery/privet_confirm_api_flow.h (right): https://codereview.chromium.org/19788004/diff/6001/chrome/browser/local_discovery/privet_confirm_api_flow.h#newcode1 ...
7 years, 5 months ago (2013-07-22 23:21:45 UTC) #5
Noam Samuel
https://codereview.chromium.org/19788004/diff/6001/chrome/browser/local_discovery/privet_confirm_api_flow.cc File chrome/browser/local_discovery/privet_confirm_api_flow.cc (right): https://codereview.chromium.org/19788004/diff/6001/chrome/browser/local_discovery/privet_confirm_api_flow.cc#newcode88 chrome/browser/local_discovery/privet_confirm_api_flow.cc:88: bool success; On 2013/07/22 23:21:45, Vitaly Buka wrote: > ...
7 years, 5 months ago (2013-07-23 00:02:41 UTC) #6
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 5 months ago (2013-07-23 00:28:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/19788004/13001
7 years, 5 months ago (2013-07-23 00:36:51 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=150852
7 years, 5 months ago (2013-07-23 02:23:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/19788004/13001
7 years, 5 months ago (2013-07-23 16:47:05 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_tests_unit.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-23 16:47:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/19788004/42001
7 years, 5 months ago (2013-07-23 20:53:24 UTC) #12
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 23:53:30 UTC) #13
Message was sent while issue was closed. 
Change committed as 213277

Powered by Google App Engine
This is Rietveld 408576698