Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 19784011: Fix test media files, that were incorrectly checked-in earlier. (Closed)

Created:
7 years, 5 months ago by shadi
Modified:
7 years, 4 months ago
Reviewers:
anandc, dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Remove media files used with tough_video_cases in favor of uploading them to google storage. Later CL commits local .sha1 files to link to uploaded media files. BUG=261318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216921

Patch Set 1 #

Patch Set 2 : Deleting local media files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-20 lines, --20 lines) Patch
M tools/perf/page_sets/tough_video_cases/crowd.ogg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/crowd.wav View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd1080.mp4 View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd1080.ogv View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd1080.webm View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd2160.mp4 View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd2160.ogv View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/crowd2160.webm View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/crowd360.mp4 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/crowd360.ogv View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/crowd360.webm View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/crowd480.webm View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/crowd720.webm View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/tulip2.m4a View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/tulip2.mp3 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/tulip2.mp4 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/tulip2.ogg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/tulip2.ogv View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/tulip2.wav View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/tulip2.webm View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
shadi
PTAL These are the same media files crrev.com/20002004 on behalf of anancd@.
7 years, 5 months ago (2013-07-23 20:26:38 UTC) #1
anandc
On 2013/07/23 20:26:38, shadi wrote: > PTAL > > These are the same media files ...
7 years, 5 months ago (2013-07-23 20:34:38 UTC) #2
shadi
PING. I need an OWNER's LGTM.
7 years, 5 months ago (2013-07-24 16:27:03 UTC) #3
tonyg
On 2013/07/24 16:27:03, shadi wrote: > PING. I need an OWNER's LGTM. How big are ...
7 years, 5 months ago (2013-07-24 16:35:03 UTC) #4
shadi
On 2013/07/24 16:35:03, tonyg wrote: > On 2013/07/24 16:27:03, shadi wrote: > > PING. I ...
7 years, 5 months ago (2013-07-24 16:54:41 UTC) #5
tonyg
On Wed, Jul 24, 2013 at 9:54 AM, <shadi@chromium.org> wrote: > On 2013/07/24 16:35:03, tonyg ...
7 years, 5 months ago (2013-07-24 17:03:47 UTC) #6
dtu
On 2013/07/24 16:54:41, shadi wrote: > On 2013/07/24 16:35:03, tonyg wrote: > > On 2013/07/24 ...
7 years, 5 months ago (2013-07-24 17:04:22 UTC) #7
shadi
On 2013/07/24 17:04:22, Dave Tu wrote: > On 2013/07/24 16:54:41, shadi wrote: > > On ...
7 years, 5 months ago (2013-07-24 17:10:46 UTC) #8
dtu
On 2013/07/24 17:10:46, shadi wrote: > On 2013/07/24 17:04:22, Dave Tu wrote: > > On ...
7 years, 5 months ago (2013-07-24 19:13:17 UTC) #9
shadi
On 2013/07/24 19:13:17, Dave Tu wrote: > On 2013/07/24 17:10:46, shadi wrote: > > On ...
7 years, 5 months ago (2013-07-24 22:18:26 UTC) #10
shadi
Let us delete those local media files. All future media files should be on GS. ...
7 years, 4 months ago (2013-07-29 21:22:15 UTC) #11
dtu
A bunch of the files in the patch set still say M. Is that an ...
7 years, 4 months ago (2013-07-30 00:05:59 UTC) #12
anandc
On 2013/07/30 00:05:59, Dave Tu wrote: > A bunch of the files in the patch ...
7 years, 4 months ago (2013-07-30 00:12:01 UTC) #13
dtu
On 2013/07/30 00:12:01, anandc wrote: > On 2013/07/30 00:05:59, Dave Tu wrote: > > A ...
7 years, 4 months ago (2013-07-30 00:13:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/19784011/14001
7 years, 4 months ago (2013-08-01 18:54:35 UTC) #15
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-01 19:55:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/19784011/14001
7 years, 4 months ago (2013-08-09 18:14:07 UTC) #17
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-09 18:25:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/19784011/14001
7 years, 4 months ago (2013-08-12 02:00:00 UTC) #19
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 05:01:24 UTC) #20
Message was sent while issue was closed.
Change committed as 216921

Powered by Google App Engine
This is Rietveld 408576698