Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 19784010: cut a bunch of dependencies from browser->blink when in chrome_multiple_dll (Closed)

Created:
7 years, 5 months ago by scottmg
Modified:
7 years, 5 months ago
Reviewers:
jamesr, jam, marja
CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Visibility:
Public.

Description

cut a bunch of dependencies from browser->blink when in chrome_multiple_dll Cuts number of gyp paths from chrome.dll -> blink from ~2000 to 113. The remaining paths are via ppapi\ppapi_internal.gyp which I'm not sure what to do with yet. This is intended as a relatively temporary measure so that chrome_multiple_dll=1 has the dependency structure that we want (no browser <-> child) with link errors so we can see what work remains. This CL causes the link errors below in chrome_multiple_dll=1. I think these will be fixed by jam@s moving of webkit/plugins/ppapi into content. content_common.lib(content_common.pepper_plugin_info.obj) : error LNK2019: unresolved external symbol "public: __thiscall webkit::ppapi::PluginModule::EntryPoints::EntryPoints(void)" (??0EntryPoints@PluginModule@ppapi@webkit@@QAE@XZ) referenced in function "public: __thiscall content::PepperPluginInfo::PepperPluginInfo(void)" (??0PepperPluginInfo@content@@QAE@XZ) content_common.lib(content_common.pepper_plugin_registry.obj) : error LNK2019: unresolved external symbol "public: __thiscall webkit::ppapi::PluginModule::~PluginModule(void)" (??1PluginModule@ppapi@webkit@@QAE@XZ) referenced in function "public: void * __thiscall webkit::ppapi::PluginModule::`scalar deleting destructor'(unsigned int)" (??_GPluginModule@ppapi@webkit@@QAEPAXI@Z) content_common.lib(content_common.pepper_plugin_registry.obj) : error LNK2019: unresolved external symbol "public: bool __thiscall webkit::ppapi::PluginModule::InitAsLibrary(class base::FilePath const &)" (?InitAsLibrary@PluginModule@ppapi@webkit@@QAE_NABVFilePath@base@@@Z) referenced in function "private: __thiscall content::PepperPluginRegistry::PepperPluginRegistry(void)" (??0PepperPluginRegistry@content@@AAE@XZ) content_common.lib(content_common.pepper_plugin_registry.obj) : error LNK2019: unresolved external symbol "public: bool __thiscall webkit::ppapi::PluginModule::InitAsInternalPlugin(struct webkit::ppapi::PluginModule::EntryPoints const &)" (?InitAsInternalPlugin@PluginModule@ppapi@webkit@@QAE_NABUEntryPoints@123@@Z) referenced in function "private: __thiscall content::PepperPluginRegistry::PepperPluginRegistry(void)" (??0PepperPluginRegistry@content@@AAE@XZ) content_common.lib(content_common.pepper_plugin_registry.obj) : error LNK2019: unresolved external symbol "public: __thiscall webkit::ppapi::PluginModule::PluginModule(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::FilePath const &,class webkit::ppapi::PluginDelegate::ModuleLifetime *,class ppapi::PpapiPermissions const &)" (??0PluginModule@ppapi@webkit@@QAE@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABVFilePath@base@@PAVModuleLifetime@PluginDelegate@12@ABVPpapiPermissions@1@@Z) referenced in function "private: __thiscall content::PepperPluginRegistry::PepperPluginRegistry(void)" (??0PepperPluginRegistry@content@@AAE@XZ) TBR=jam@chromium.org R=jamesr@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213325

Patch Set 1 #

Patch Set 2 : ios #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M chrome/chrome_browser_extensions.gypi View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M components/sessions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M webkit/storage_browser.gyp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
7 years, 5 months ago (2013-07-23 19:52:31 UTC) #1
jamesr
lgtm I think several of these can be removed completely or at least replaced with ...
7 years, 5 months ago (2013-07-23 20:07:40 UTC) #2
scottmg
tbr jam for content/chrome (only affects chrome_multiple_dll build)
7 years, 5 months ago (2013-07-23 23:23:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/19784010/4001
7 years, 5 months ago (2013-07-23 23:25:02 UTC) #4
commit-bot: I haz the power
Failed to apply patch for webkit/glue/webkit_glue.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-23 23:25:05 UTC) #5
scottmg
oops, and tbr marja for components/sessions/
7 years, 5 months ago (2013-07-23 23:33:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/19784010/15001
7 years, 5 months ago (2013-07-23 23:33:50 UTC) #7
jam
lgtm
7 years, 5 months ago (2013-07-23 23:39:33 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 02:50:02 UTC) #9
Message was sent while issue was closed.
Change committed as 213325

Powered by Google App Engine
This is Rietveld 408576698