Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 19784004: Track all non-hole global constants. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest
Modified:
7 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Track all non-hole global constants. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/objects.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 5 months ago (2013-07-22 12:06:13 UTC) #1
mvstanton
As long as mozilla/test262 pass, this lgtm.
7 years, 5 months ago (2013-07-22 12:08:57 UTC) #2
Toon Verwaest
7 years, 5 months ago (2013-07-22 12:15:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698