Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: Source/devtools/front_end/InspectorView.js

Issue 197823010: [DevTools] Add minimum size to WebInspector.View. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@splitdip2
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/InspectorView.js
diff --git a/Source/devtools/front_end/InspectorView.js b/Source/devtools/front_end/InspectorView.js
index cb1ffaa19252b8d982c28526bdc8d947fe3c0c27..7d3dc73a831bbf731cb9bb54ac5b1a9f3860e9df 100644
--- a/Source/devtools/front_end/InspectorView.js
+++ b/Source/devtools/front_end/InspectorView.js
@@ -36,13 +36,12 @@ WebInspector.InspectorView = function()
{
WebInspector.VBox.call(this);
WebInspector.Dialog.setModalHostView(this);
+ this.setMinimumSize(180, 72);
// DevTools sidebar is a vertical split of panels tabbed pane and a drawer.
this._drawerSplitView = new WebInspector.SplitView(false, true, "Inspector.drawerSplitViewState", 200, 200);
this._drawerSplitView.hideSidebar();
this._drawerSplitView.enableShowModeSaving();
- this._drawerSplitView.setSidebarElementConstraints(Preferences.minDrawerHeight, Preferences.minDrawerHeight);
- this._drawerSplitView.setMainElementConstraints(25, 25);
this._drawerSplitView.show(this.element);
this._tabbedPane = new WebInspector.TabbedPane();
@@ -440,11 +439,44 @@ WebInspector.RootView = function()
{
WebInspector.VBox.call(this);
this.markAsRoot();
- this.element.classList.add("fill", "root-view");
+ this.element.classList.add("root-view");
this.element.setAttribute("spellcheck", false);
window.addEventListener("resize", this.doResize.bind(this), true);
+ window.addEventListener("scroll", this._onScroll.bind(this), false);
};
WebInspector.RootView.prototype = {
+ attachToBody: function()
+ {
+ var body = document.body;
+ body.style.height = "100%";
+ body.style.width = "100%";
vsevik 2014/03/25 12:30:51 Let's move this to css.
dgozman 2014/03/25 14:13:58 Done.
+ body.style.overflow = "hidden";
+ this.doResize();
+ this.show(body);
+ },
+
+ _onScroll: function()
+ {
+ // If we didn't have enough space at the start, we may have wrong scroll offsets.
+ if (document.body.scrollTop !== 0)
+ document.body.scrollTop = 0;
+ if (document.body.scrollLeft !== 0)
+ document.body.scrollLeft = 0;
+ },
+
+ doResize: function()
+ {
+ var size = this.minimumSize();
+ var right = Math.min(0, window.innerWidth - size.width);
+ this.element.style.right = right + "px";
+ var bottom = Math.min(0, window.innerHeight - size.height);
+ this.element.style.bottom = bottom + "px";
vsevik 2014/03/25 13:26:04 Let's set scroll listener when the size is not eno
dgozman 2014/03/25 14:13:58 Done.
+
+ WebInspector.VBox.prototype.doResize.call(this);
+ document.body.scrollTop = 0;
+ document.body.scrollLeft = 0;
+ },
+
__proto__: WebInspector.VBox.prototype
};

Powered by Google App Engine
This is Rietveld 408576698