Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Unified Diff: Source/devtools/front_end/SourcesPanel.js

Issue 197823010: [DevTools] Add minimum size to WebInspector.View. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@splitdip2
Patch Set: width/height -> right/bottom Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/SourcesPanel.js
diff --git a/Source/devtools/front_end/SourcesPanel.js b/Source/devtools/front_end/SourcesPanel.js
index fba5ba6ace557ea3e3e42ff271ded6f986f5b501..b41f332186c19f231499772bd9ce87e2a3d62bb5 100644
--- a/Source/devtools/front_end/SourcesPanel.js
+++ b/Source/devtools/front_end/SourcesPanel.js
@@ -74,9 +74,6 @@ WebInspector.SourcesPanel = function(workspaceForTest)
const initialDebugSidebarWidth = 225;
this._splitView = new WebInspector.SplitView(true, true, "sourcesPanelSplitViewState", initialDebugSidebarWidth);
this._splitView.enableShowModeSaving();
- this._splitView.setMainElementConstraints(200, 25);
- this._splitView.setSidebarElementConstraints(WebInspector.SourcesPanel.minToolbarWidth, 25);
-
this._splitView.show(this.element);
// Create scripts navigator
@@ -85,12 +82,10 @@ WebInspector.SourcesPanel = function(workspaceForTest)
this.editorView.enableShowModeSaving();
this.editorView.element.id = "scripts-editor-split-view";
this.editorView.element.tabIndex = 0;
-
- this.editorView.setSidebarElementConstraints(Preferences.minSidebarWidth);
- this.editorView.setMainElementConstraints(50, 50);
this.editorView.show(this._splitView.mainElement());
this._navigator = new WebInspector.SourcesNavigator(this._workspace);
+ this._navigator.view.setMinimumSize(Preferences.minSidebarWidth, 25);
this._navigator.view.show(this.editorView.sidebarElement());
var tabbedEditorPlaceholderText = WebInspector.isMac() ? WebInspector.UIString("Hit Cmd+O to open a file") : WebInspector.UIString("Hit Ctrl+O to open a file");
@@ -214,7 +209,7 @@ WebInspector.SourcesPanel = function(workspaceForTest)
window.addEventListener("beforeunload", handleBeforeUnload, true);
}
-WebInspector.SourcesPanel.minToolbarWidth = 215;
+WebInspector.SourcesPanel.minToolbarWidth = 185;
vsevik 2014/03/19 16:59:49 This is important to keep the old value because we
dgozman 2014/03/19 19:43:49 We decided with Pavel that it's not worth it. Extr
WebInspector.SourcesPanel.Events = {
EditorClosed: "EditorClosed",
@@ -1486,6 +1481,7 @@ WebInspector.SourcesPanel.prototype = {
vbox.element.appendChild(this._debugToolbarDrawer);
vbox.element.appendChild(this.debugToolbar);
vbox.element.appendChild(this.threadsToolbar.element);
+ vbox.setMinimumSize(WebInspector.SourcesPanel.minToolbarWidth, 25);
var sidebarPaneStack = new WebInspector.SidebarPaneStack();
sidebarPaneStack.element.classList.add("flex-auto");
sidebarPaneStack.show(vbox.element);
@@ -1499,7 +1495,6 @@ WebInspector.SourcesPanel.prototype = {
this.sidebarPaneView = vbox;
} else {
var splitView = new WebInspector.SplitView(true, true, "sourcesPanelDebuggerSidebarSplitViewState", 0.5);
- splitView.setMainElementConstraints(WebInspector.SourcesPanel.minToolbarWidth, 25);
vbox.show(splitView.mainElement());
// Populate the left stack.
@@ -1561,6 +1556,7 @@ WebInspector.SourcesPanel.prototype = {
WebInspector.SourcesView = function()
{
WebInspector.VBox.call(this);
+ this.setMinimumSize(50, 25);
this.registerRequiredCSS("sourcesView.css");
this.element.id = "sources-panel-sources-view";
this.element.addEventListener("dragenter", this._onDragEnter.bind(this), true);

Powered by Google App Engine
This is Rietveld 408576698