[DevTools] Add minimum size to WebInspector.View.

Source/devtools/front_end/InspectorView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.InspectorView = function()
 {
     WebInspector.VBox.call(this);
     WebInspector.Dialog.setModalHostView(this);
+    this.setMinimumSize(180, 72);
 
     // DevTools sidebar is a vertical split of panels tabbed pane and a drawer.
     this._drawerSplitView = new WebInspector.SplitView(false, true, "Inspector.drawerSplitViewState", 200, 200);
     this._drawerSplitView.hideSidebar();
     this._drawerSplitView.enableShowModeSaving();
-    this._drawerSplitView.setSidebarElementConstraints(Preferences.minDrawerHeight, Preferences.minDrawerHeight);
-    this._drawerSplitView.setMainElementConstraints(25, 25);
     this._drawerSplitView.show(this.element);
 
     this._tabbedPane = new WebInspector.TabbedPane();
     this._tabbedPane.setRetainTabOrder(true, WebInspector.moduleManager.orderComparator(WebInspector.Panel, "name", "order"));
     this._tabbedPane.show(this._drawerSplitView.mainElement());
     this._drawer = new WebInspector.Drawer(this._drawerSplitView);
 
     // Patch tabbed pane header with toolbar actions.
     this._toolbarElement = document.createElement("div");
     this._toolbarElement.className = "toolbar toolbar-background";
@@ skipping 377 matching lines @@
 WebInspector.inspectorView;
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.RootView = function()
 {
     WebInspector.VBox.call(this);
     this.markAsRoot();
-    this.element.classList.add("fill", "root-view");
+    this.element.classList.add("root-view");
     this.element.setAttribute("spellcheck", false);
     window.addEventListener("resize", this.doResize.bind(this), true);
+    window.addEventListener("scroll", this._onScroll.bind(this), false);
 };
 
 WebInspector.RootView.prototype = {
+    attachToBody: function()
+    {
+        var body = document.body;
+        body.style.height = "100%";
+        body.style.width = "100%";

[vsevik, 2014/03/25 12:30:51]

Let's move this to css.

[dgozman, 2014/03/25 14:13:58]

Done.

+        body.style.overflow = "hidden";
+        this.doResize();
+        this.show(body);
+    },
+
+    _onScroll: function()
+    {
+        // If we didn't have enough space at the start, we may have wrong scroll offsets.
+        if (document.body.scrollTop !== 0)
+            document.body.scrollTop = 0;
+        if (document.body.scrollLeft !== 0)
+            document.body.scrollLeft = 0;
+    },
+
+    doResize: function()
+    {
+        var size = this.minimumSize();
+        var right = Math.min(0, window.innerWidth - size.width);
+        this.element.style.right = right + "px";
+        var bottom = Math.min(0, window.innerHeight - size.height);
+        this.element.style.bottom = bottom + "px";

[vsevik, 2014/03/25 13:26:04]

Let's set scroll listener when the size is not enough only, so that we could me
sure that this is something that is done very rarely.

[dgozman, 2014/03/25 14:13:58]

Done.

+
+        WebInspector.VBox.prototype.doResize.call(this);
+        document.body.scrollTop = 0;
+        document.body.scrollLeft = 0;
+    },
+
     __proto__: WebInspector.VBox.prototype
 };