[DevTools] Add minimum size to WebInspector.View.

Source/devtools/front_end/SourcesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 56 matching lines @@
     this._workspace = workspaceForTest || WebInspector.workspace;
 
     var helpSection = WebInspector.shortcutsScreen.section(WebInspector.UIString("Sources Panel"));
     this.debugToolbar = this._createDebugToolbar();
     this._debugToolbarDrawer = this._createDebugToolbarDrawer();
     this.threadsToolbar = new WebInspector.ThreadsToolbar();
 
     const initialDebugSidebarWidth = 225;
     this._splitView = new WebInspector.SplitView(true, true, "sourcesPanelSplitViewState", initialDebugSidebarWidth);
     this._splitView.enableShowModeSaving();
-    this._splitView.setMainElementConstraints(200, 25);
-    this._splitView.setSidebarElementConstraints(WebInspector.SourcesPanel.minToolbarWidth, 25);
-
     this._splitView.show(this.element);
 
     // Create scripts navigator
     const initialNavigatorWidth = 225;
     this.editorView = new WebInspector.SplitView(true, false, "sourcesPanelNavigatorSplitViewState", initialNavigatorWidth);
     this.editorView.enableShowModeSaving();
     this.editorView.element.id = "scripts-editor-split-view";
     this.editorView.element.tabIndex = 0;
-
-    this.editorView.setSidebarElementConstraints(Preferences.minSidebarWidth);
-    this.editorView.setMainElementConstraints(50, 50);
     this.editorView.show(this._splitView.mainElement());
 
     this._navigator = new WebInspector.SourcesNavigator(this._workspace);
+    this._navigator.view.setMinimumSize(Preferences.minSidebarWidth, 25);
     this._navigator.view.show(this.editorView.sidebarElement());
 
     var tabbedEditorPlaceholderText = WebInspector.isMac() ? WebInspector.UIString("Hit Cmd+O to open a file") : WebInspector.UIString("Hit Ctrl+O to open a file");
 
     this._drawerEditorView = new WebInspector.SourcesPanel.DrawerEditorView();
     this.sourcesView = new WebInspector.SourcesView();
     this.sourcesView.show(this._drawerEditorView.element);
 
     this._searchableView = new WebInspector.SearchableView(this);
     this._searchableView.setMinimalSearchQuerySize(0);
@@ skipping 103 matching lines @@
             return;
 
         event.returnValue = WebInspector.UIString("DevTools have unsaved changes that will be permanently lost.");
         WebInspector.inspectorView.showPanel("sources");
         for (var i = 0; i < unsavedSourceCodes.length; ++i)
             WebInspector.panels.sources.showUISourceCode(unsavedSourceCodes[i]);
     }
     window.addEventListener("beforeunload", handleBeforeUnload, true);
 }
 
-WebInspector.SourcesPanel.minToolbarWidth = 215;
+WebInspector.SourcesPanel.minToolbarWidth = 185;

[vsevik, 2014/03/19 16:59:49]

This is important to keep the old value because we have a run snippet button
which not always shown.

[dgozman, 2014/03/19 19:43:49]

We decided with Pavel that it's not worth it. Extra button is just clipped now,
not messing with layout.

 
 WebInspector.SourcesPanel.Events = {
     EditorClosed: "EditorClosed",
     EditorSelected: "EditorSelected",
 }
 
 WebInspector.SourcesPanel.prototype = {
     /**
      * @param {?Event=} event
      */
@@ skipping 1251 matching lines @@
         if (!vertically)
             this._splitView.uninstallResizer(this._statusBarContainerElement);
         else
             this._splitView.installResizer(this._statusBarContainerElement);
 
         // Create vertical box with stack.
         var vbox = new WebInspector.VBox();
         vbox.element.appendChild(this._debugToolbarDrawer);
         vbox.element.appendChild(this.debugToolbar);
         vbox.element.appendChild(this.threadsToolbar.element);
+        vbox.setMinimumSize(WebInspector.SourcesPanel.minToolbarWidth, 25);
         var sidebarPaneStack = new WebInspector.SidebarPaneStack();
         sidebarPaneStack.element.classList.add("flex-auto");
         sidebarPaneStack.show(vbox.element);
 
         if (!vertically) {
             // Populate the only stack.
             for (var pane in this.sidebarPanes)
                 sidebarPaneStack.addPane(this.sidebarPanes[pane]);
             this._extensionSidebarPanesContainer = sidebarPaneStack;
 
             this.sidebarPaneView = vbox;
         } else {
             var splitView = new WebInspector.SplitView(true, true, "sourcesPanelDebuggerSidebarSplitViewState", 0.5);
-            splitView.setMainElementConstraints(WebInspector.SourcesPanel.minToolbarWidth, 25);
             vbox.show(splitView.mainElement());
 
             // Populate the left stack.
             sidebarPaneStack.addPane(this.sidebarPanes.callstack);
             sidebarPaneStack.addPane(this.sidebarPanes.jsBreakpoints);
             sidebarPaneStack.addPane(this.sidebarPanes.domBreakpoints);
             sidebarPaneStack.addPane(this.sidebarPanes.xhrBreakpoints);
             sidebarPaneStack.addPane(this.sidebarPanes.eventListenerBreakpoints);
             if (this.sidebarPanes.workerList)
                 sidebarPaneStack.addPane(this.sidebarPanes.workerList);
@@ skipping 41 matching lines @@
     __proto__: WebInspector.Panel.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.SourcesView = function()
 {
     WebInspector.VBox.call(this);
+    this.setMinimumSize(50, 25);
     this.registerRequiredCSS("sourcesView.css");
     this.element.id = "sources-panel-sources-view";
     this.element.addEventListener("dragenter", this._onDragEnter.bind(this), true);
     this.element.addEventListener("dragover", this._onDragOver.bind(this), true);
 }
 
 WebInspector.SourcesView.dragAndDropFilesType = "Files";
 
 WebInspector.SourcesView.prototype = {
     _onDragEnter: function (event)
@@ skipping 148 matching lines @@
 {
 }
 
 WebInspector.SourcesPanel.EditorAction.prototype = {
     /**
      * @param {!WebInspector.SourcesPanel} panel
      * @return {!Element}
      */
     button: function(panel) { }
 }