Translate: Remove the legacy pref 'translate_language_blacklist'

Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one use. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"

Committed: https://crrev.com/e74d2bc1307e28656cc611446defc02350c22608
Cr-Commit-Position: refs/heads/master@{#394357}

[hajimehoshi, 2016-05-16 10:16:51]

Description was changed from

==========
Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one uses. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"
==========

to

==========
Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one uses. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"
==========

[hajimehoshi, 2016-05-16 10:16:51]

hajimehoshi@chromium.org changed reviewers:
+ toyoshim@chromium.org

[hajimehoshi, 2016-05-16 10:19:53]

Description was changed from

==========
Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one uses. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"
==========

to

==========
Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one use. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"
==========

[hajimehoshi, 2016-05-16 10:21:10]

hajimehoshi@chromium.org changed reviewers:
+ groby@chromium.org
- toyoshim@chromium.org

[hajimehoshi, 2016-05-16 10:21:46]

PTAL

[groby-ooo-7-16, 2016-05-17 22:16:27]

That is fantastic, thank you - LGTM. With one tiny question: Do you think it's
worth adding a cleanup section that removes this from the preferences file, or
is this so small we don't need to care?

[groby-ooo-7-16, 2016-05-17 22:21:30]

groby@chromium.org changed reviewers:
+ dbeam@chromium.org

[groby-ooo-7-16, 2016-05-17 22:21:31]

+dbeam for webui OWNERS

[Dan Beam, 2016-05-17 22:53:44]

lgtm

[hajimehoshi, 2016-05-18 04:50:26]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-05-18 04:50:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978203002/1

[hajimehoshi, 2016-05-18 04:51:48]

On 2016/05/17 22:16:27, groby wrote:
> That is fantastic, thank you - LGTM. With one tiny question: Do you think it's
> worth adding a cleanup section that removes this from the preferences file, or
> is this so small we don't need to care?

Thank you! What is the preferences file you mentioned?

[commit-bot: I haz the power, 2016-05-18 05:42:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 05:42:49]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[hajimehoshi, 2016-05-18 07:13:51]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-05-18 07:14:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978203002/1

[commit-bot: I haz the power, 2016-05-18 08:08:57]

Description was changed from

==========
Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one use. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"
==========

to

==========
Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one use. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"
==========

[commit-bot: I haz the power, 2016-05-18 08:08:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-18 08:11:04]

Description was changed from

==========
Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one use. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"
==========

to

==========
Translate: Remove the legacy pref 'translate_language_blacklist'

'translate_language_blacklist' was replaced by
'translate_blocked_languages' at M31, which almost no one use. Let's
remove this legacy pref and its migration logic for code health.

BUG=591937
TEST=components_unittest --gtest_filter="TranslatePrefTest.*"

Committed: https://crrev.com/e74d2bc1307e28656cc611446defc02350c22608
Cr-Commit-Position: refs/heads/master@{#394357}
==========

[commit-bot: I haz the power, 2016-05-18 08:11:05]

Patchset 1 (id:??) landed as
https://crrev.com/e74d2bc1307e28656cc611446defc02350c22608
Cr-Commit-Position: refs/heads/master@{#394357}