Issue 19777004: Catch and print OSError instead of Exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19777004: Catch and print OSError instead of Exception. (Closed)

Created:
7 years, 5 months ago by iannucci

Modified:
7 years, 5 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Catch and print OSError instead of Exception. Also open the altfile with 'w' because we assume ownership over the object alternates. The logic to correctly support other alternates would be quite complex, so don't even imply support. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=212426

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use stderr #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	gclient_scm.py	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://codereview.chromium.org/19777004/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/19777004/diff/1/gclient_scm.py#newcode777 gclient_scm.py:777: print "FAILED: os.remove('%s') -> %s" % (altfile, e) ...

7 years, 5 months ago (2013-07-18 19:14:52 UTC) #2

iannucci

On 2013/07/18 19:14:52, Marc-Antoine Ruel wrote: > lgtm > > https://codereview.chromium.org/19777004/diff/1/gclient_scm.py > File gclient_scm.py (right): ...

7 years, 5 months ago (2013-07-18 20:52:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/19777004/5001

7 years, 5 months ago (2013-07-18 20:53:06 UTC) #4

Message was sent while issue was closed.

Change committed as 212426

Expand Messages | Collapse Messages