[Passwords, Mac] Don't always prompt to access passwords saved by other browsers

chrome/browser/password_manager/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager.h"
 
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/platform_thread.h"
 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
+#include "chrome/browser/password_manager/password_store.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/pref_names.h"
 #include "components/autofill/core/common/autofill_messages.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "grit/generated_resources.h"
@@ skipping 232 matching lines @@
       continue;
 
     bool ssl_valid = iter->origin.SchemeIsSecure() && !had_ssl_error;
     PasswordFormManager* manager =
         new PasswordFormManager(delegate_->GetProfile(),
                                 this,
                                 web_contents(),
                                 *iter,
                                 ssl_valid);
     pending_login_managers_.push_back(manager);
-    manager->FetchMatchingLoginsFromPasswordStore();
+    PasswordStore::AuthorizationPromptPermission prompt_permission =
+        *password_manager_enabled_ ?
+        PasswordStore::ALLOW_PROMPT :
+        PasswordStore::DISALLOW_PROMPT;

[stuartmorgan, 2013/08/29 20:39:54]

Optional: Looks like it would fit to pull this up to:
   foo ? bar
       : baz
which seems more readable; this looks like an argument list rather than a
ternary to me when skimming.

+    manager->FetchMatchingLoginsFromPasswordStore(prompt_permission);
   }
 }
 
 bool PasswordManager::ShouldShowSavePasswordInfoBar() const {
   return provisional_save_manager_->IsNewLogin() &&
       !provisional_save_manager_->HasGeneratedPassword() &&
       !provisional_save_manager_->IsPendingCredentialsPublicSuffixMatch();
 }
 
 void PasswordManager::OnPasswordFormsRendered(
@@ skipping 102 matching lines @@
       return;
     }
     default:
       FOR_EACH_OBSERVER(
           LoginModelObserver,
           observers_,
           OnAutofillDataAvailable(preferred_match.username_value,
                                   preferred_match.password_value));
   }
 }