Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3054)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 19774008: Do not reboot emulator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index b1769ee2375391bcac39f44d79e47a3ebecef610..3b0c30923ab4a46e00817f6f64683f4d89ea60df 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -84,7 +84,12 @@ def RebootDevices():
# which might not exist in this checkout.
if bb_utils.TESTING:
return
- devices = android_commands.GetAttachedDevices()
+ all_devices = android_commands.GetAttachedDevices()
frankf 2013/07/19 19:20:31 Instead of adding all this extra logic here, combi
Isaac (away) 2013/07/19 21:31:29 Yeah I agree w/ frank. Let's push this logic into
navabi 2013/07/19 23:03:44 Done. Good idea.
+
+ def IsRealDevice(device):
+ return device not in android_commands.GetEmulators()
+
+ devices = filter(IsRealDevice, all_devices)
print 'Rebooting: %s' % devices
if devices:
pool = multiprocessing.Pool(len(devices))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698