Issue 19773012: [chromedriver] Accept loadAsync as a non-op chromeOption.

Issue 19773012: [chromedriver] Accept loadAsync as a non-op chromeOption. (Closed)

Created:
7 years, 5 months ago by chrisgao (Use stgao instead)

Modified:
7 years, 4 months ago

Reviewers:
kkania

CC:
chromium-reviews, kkania, frankf

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Accept loadAsync as a non-op chromeOption. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217147

Patch Set 2 : Accept but ignore loadAsync. #

Total comments: 2

Patch Set 3 : Address comment on log. #

Patch Set 4 : Fix unittest. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -27 lines)			Patch
M	chrome/test/chromedriver/capabilities.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/capabilities.cc	View	1 2	6 chunks	+20 lines, -2 lines	0 comments	Download
M	chrome/test/chromedriver/capabilities_unittest.cc	View	1 2 3	24 chunks	+47 lines, -23 lines	0 comments	Download
M	chrome/test/chromedriver/commands.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

chrisgao (Use stgao instead)

Accept loadAsync as a non-op chromeOption. And give a warning on deprecated options like loadAsync.

7 years, 4 months ago (2013-08-09 21:57:13 UTC) #3

kkania

lgtm https://codereview.chromium.org/19773012/diff/7001/chrome/test/chromedriver/capabilities.cc File chrome/test/chromedriver/capabilities.cc (right): https://codereview.chromium.org/19773012/diff/7001/chrome/test/chromedriver/capabilities.cc#newcode33 chrome/test/chromedriver/capabilities.cc:33: LOG(WARNING) << "deprecated option is ignored:" << option_name; ...

7 years, 4 months ago (2013-08-12 17:13:04 UTC) #4

chrisgao (Use stgao instead)

https://codereview.chromium.org/19773012/diff/7001/chrome/test/chromedriver/capabilities.cc File chrome/test/chromedriver/capabilities.cc (right): https://codereview.chromium.org/19773012/diff/7001/chrome/test/chromedriver/capabilities.cc#newcode33 chrome/test/chromedriver/capabilities.cc:33: LOG(WARNING) << "deprecated option is ignored:" << option_name; On ...

7 years, 4 months ago (2013-08-12 20:14:33 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/19773012/13001

7 years, 4 months ago (2013-08-12 20:23:11 UTC) #6

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 4 months ago (2013-08-12 21:14:17 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/19773012/40001

7 years, 4 months ago (2013-08-12 21:39:14 UTC) #8

Message was sent while issue was closed.

Change committed as 217147

Expand Messages | Collapse Messages