Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19772005: [telemetry] Timeline model cleanups (Closed)

Created:
7 years, 5 months ago by nduca
Modified:
7 years, 5 months ago
Reviewers:
achuithb, Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, tfarina, telemetry+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : benchmarks work now #

Patch Set 3 : Move things around and update docs #

Patch Set 4 : Move things around and update docs #

Total comments: 5

Patch Set 5 : Fix parenting #

Total comments: 3

Patch Set 6 : Fixes per feedback #

Patch Set 7 : silly reitveld #

Total comments: 1

Patch Set 8 : with_itertoosl #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+949 lines, -3125 lines) Patch
M tools/telemetry/docs/telemetry.html View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.browser.html View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.html View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.adb_commands.html View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.android_browser_backend.html View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.android_browser_finder.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.browser_backend.html View 1 2 3 chunks +10 lines, -7 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.cros_browser_backend.html View 1 2 4 chunks +11 lines, -8 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.cros_browser_finder.html View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.cros_interface.html View 1 2 2 chunks +3 lines, -1 line 0 comments Download
D tools/telemetry/docs/telemetry.core.chrome.cros_util.html View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.desktop_browser_backend.html View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.desktop_browser_finder.html View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.tab_list_backend.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.tracing_backend.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.memory_cache_http_server.html View 1 2 5 chunks +4 lines, -9 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.platform.profiler.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.platform.profiler.profiler_finder.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.platform.profiler.trace_profiler.html View 1 2 4 chunks +13 lines, -17 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.timeline.html View 1 2 1 chunk +15 lines, -5 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.timeline.async_slice.html View 1 2 7 chunks +10 lines, -29 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.timeline.bounds.html View 1 2 4 chunks +23 lines, -13 lines 0 comments Download
A tools/telemetry/docs/telemetry.core.timeline.counter.html View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.timeline.event.html View 1 2 2 chunks +1 line, -13 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.timeline.event_container.html View 1 2 4 chunks +11 lines, -17 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.timeline.inspector_importer.html View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.timeline.model.html View 1 2 3 chunks +15 lines, -9 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.timeline.process.html View 1 2 6 chunks +17 lines, -29 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.timeline.sample.html View 1 2 5 chunks +5 lines, -17 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.timeline.slice.html View 1 2 5 chunks +12 lines, -19 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.timeline.thread.html View 1 2 7 chunks +22 lines, -30 lines 0 comments Download
A + tools/telemetry/docs/telemetry.core.timeline.trace_event_importer.html View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
D tools/telemetry/docs/telemetry.core.timeline.tracing.html View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D tools/telemetry/docs/telemetry.core.timeline.tracing.async_slice.html View 1 2 1 chunk +0 lines, -96 lines 0 comments Download
D tools/telemetry/docs/telemetry.core.timeline.tracing.counter.html View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
D tools/telemetry/docs/telemetry.core.timeline.tracing.process.html View 1 2 1 chunk +0 lines, -99 lines 0 comments Download
D tools/telemetry/docs/telemetry.core.timeline.tracing.sample.html View 1 2 1 chunk +0 lines, -89 lines 0 comments Download
D tools/telemetry/docs/telemetry.core.timeline.tracing.slice.html View 1 2 1 chunk +0 lines, -97 lines 0 comments Download
D tools/telemetry/docs/telemetry.core.timeline.tracing.thread.html View 1 2 1 chunk +0 lines, -126 lines 0 comments Download
D tools/telemetry/docs/telemetry.core.timeline.tracing.trace_event_importer.html View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.user_agent.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.wpr_server.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.page.html View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M tools/telemetry/docs/telemetry.page.actions.html View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
A + tools/telemetry/docs/telemetry.page.actions.play.html View 1 2 5 chunks +28 lines, -20 lines 0 comments Download
A + tools/telemetry/docs/telemetry.page.cloud_storage.html View 1 2 2 chunks +16 lines, -12 lines 0 comments Download
M tools/telemetry/docs/telemetry.page.page_runner.html View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M tools/telemetry/docs/telemetry.page.record_wpr.html View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/chrome/tracing_backend.py View 1 chunk +3 lines, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/timeline/async_slice.py View 1 2 3 4 1 chunk +13 lines, -6 lines 0 comments Download
A tools/telemetry/telemetry/core/timeline/bounds.py View 1 chunk +71 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/core/timeline/counter.py View 1 2 3 4 5 4 chunks +42 lines, -21 lines 0 comments Download
M tools/telemetry/telemetry/core/timeline/event.py View 1 2 3 4 2 chunks +2 lines, -46 lines 0 comments Download
A tools/telemetry/telemetry/core/timeline/event_container.py View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/timeline/event_unittest.py View 1 chunk +1 line, -20 lines 0 comments Download
M tools/telemetry/telemetry/core/timeline/inspector_importer.py View 1 2 3 chunks +29 lines, -42 lines 0 comments Download
M tools/telemetry/telemetry/core/timeline/inspector_importer_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/timeline/model.py View 1 2 3 chunks +59 lines, -44 lines 0 comments Download
M tools/telemetry/telemetry/core/timeline/model_unittest.py View 1 chunk +1 line, -11 lines 0 comments Download
A + tools/telemetry/telemetry/core/timeline/process.py View 1 2 3 chunks +27 lines, -24 lines 0 comments Download
A + tools/telemetry/telemetry/core/timeline/sample.py View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A tools/telemetry/telemetry/core/timeline/slice.py View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/timeline/slice_unittest.py View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/core/timeline/thread.py View 1 2 3 4 5 6 7 6 chunks +55 lines, -36 lines 0 comments Download
A + tools/telemetry/telemetry/core/timeline/trace_event_importer.py View 1 2 3 4 5 chunks +5 lines, -17 lines 0 comments Download
A + tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py View 1 2 43 chunks +132 lines, -141 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/__init__.py View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/async_slice.py View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/counter.py View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/process.py View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/sample.py View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/slice.py View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/thread.py View 1 2 1 chunk +0 lines, -182 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/trace_event_importer.py View 1 2 1 chunk +0 lines, -361 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/tracing/trace_event_importer_unittest.py View 1 2 1 chunk +0 lines, -930 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nduca
ptal, different issue number because reitveld had a temper tantrum
7 years, 5 months ago (2013-07-18 19:53:14 UTC) #1
Tim Song
https://codereview.chromium.org/19772005/diff/1/tools/telemetry/telemetry/core/timeline/tracing/async_slice.py File tools/telemetry/telemetry/core/timeline/tracing/async_slice.py (right): https://codereview.chromium.org/19772005/diff/1/tools/telemetry/telemetry/core/timeline/tracing/async_slice.py#newcode20 tools/telemetry/telemetry/core/timeline/tracing/async_slice.py:20: def AddSubSlice(self, sub_slice): It seems odd that AddSubSlice assumes ...
7 years, 5 months ago (2013-07-18 21:49:31 UTC) #2
nduca
We can do parent improvements as a followup. This is a pretty good step forward.
7 years, 5 months ago (2013-07-18 22:16:20 UTC) #3
Tim Song
Please look at comments in the last patch set before the parent changes as well. ...
7 years, 5 months ago (2013-07-18 22:56:36 UTC) #4
nduca
some comments https://codereview.chromium.org/19772005/diff/1/tools/telemetry/telemetry/core/timeline/tracing/async_slice.py File tools/telemetry/telemetry/core/timeline/tracing/async_slice.py (right): https://codereview.chromium.org/19772005/diff/1/tools/telemetry/telemetry/core/timeline/tracing/async_slice.py#newcode20 tools/telemetry/telemetry/core/timeline/tracing/async_slice.py:20: def AddSubSlice(self, sub_slice): I updated this to ...
7 years, 5 months ago (2013-07-18 23:03:40 UTC) #5
Tim Song
lgtm https://codereview.chromium.org/19772005/diff/19076/tools/telemetry/telemetry/core/timeline/thread.py File tools/telemetry/telemetry/core/timeline/thread.py (right): https://codereview.chromium.org/19772005/diff/19076/tools/telemetry/telemetry/core/timeline/thread.py#newcode61 tools/telemetry/telemetry/core/timeline/thread.py:61: for s in self._open_slices: There is a convenience ...
7 years, 5 months ago (2013-07-18 23:13:55 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 5 months ago (2013-07-18 23:21:26 UTC) #7
achuithb
On 2013/07/18 23:21:26, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
7 years, 5 months ago (2013-07-18 23:22:52 UTC) #8
nduca
hehe thanks!
7 years, 5 months ago (2013-07-18 23:25:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/19772005/18002
7 years, 5 months ago (2013-07-18 23:27:31 UTC) #10
commit-bot: I haz the power
7 years, 5 months ago (2013-07-19 10:50:35 UTC) #11
Message was sent while issue was closed. 
Change committed as 212559

Powered by Google App Engine
This is Rietveld 408576698