Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1977173002: Rename media::interfaces to media::mojom. (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename media::interfaces to media::mojom. BUG=597968 Committed: https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3 Cr-Commit-Position: refs/heads/master@{#394169}

Patch Set 1 #

Total comments: 2

Patch Set 2 : more files #

Patch Set 3 : android + chromeos files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+534 lines, -580 lines) Patch
M chrome/browser/chromeos/attestation/platform_verification_impl.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/output_protection_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/media/output_protection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/android/provision_fetcher_impl.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/media/android/provision_fetcher_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_interface_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_interface_provider.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M media/base/audio_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/common/media_type_converters.h View 1 chunk +40 lines, -43 lines 0 comments Download
M media/mojo/common/media_type_converters.cc View 22 chunks +120 lines, -131 lines 0 comments Download
M media/mojo/common/media_type_converters_unittest.cc View 19 chunks +20 lines, -27 lines 0 comments Download
M media/mojo/common/mojo_shared_buffer_video_frame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/interfaces/audio_decoder.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/content_decryption_module.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/decryptor.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/demuxer_stream.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/output_protection.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/platform_verification.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/provision_fetcher.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/renderer.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/service_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/apptest_manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/demuxer_stream_provider_shim.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/mojo/services/demuxer_stream_provider_shim.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/media_mojo_unittest.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M media/mojo/services/mojo_audio_decoder.h View 1 5 chunks +8 lines, -9 lines 0 comments Download
M media/mojo/services/mojo_audio_decoder.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M media/mojo/services/mojo_audio_decoder_service.h View 3 chunks +9 lines, -9 lines 0 comments Download
M media/mojo/services/mojo_audio_decoder_service.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M media/mojo/services/mojo_cdm.h View 7 chunks +15 lines, -15 lines 0 comments Download
M media/mojo/services/mojo_cdm.cc View 10 chunks +12 lines, -16 lines 0 comments Download
M media/mojo/services/mojo_cdm_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_cdm_promise.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_cdm_promise.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.h View 4 chunks +21 lines, -25 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 13 chunks +24 lines, -27 lines 0 comments Download
M media/mojo/services/mojo_decoder_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_decryptor.h View 3 chunks +11 lines, -11 lines 0 comments Download
M media/mojo/services/mojo_decryptor.cc View 12 chunks +22 lines, -23 lines 0 comments Download
M media/mojo/services/mojo_decryptor_service.h View 2 chunks +16 lines, -16 lines 0 comments Download
M media/mojo/services/mojo_decryptor_service.cc View 10 chunks +16 lines, -17 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.h View 2 chunks +13 lines, -13 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.h View 2 chunks +7 lines, -8 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_provision_fetcher.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_provision_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 4 chunks +9 lines, -9 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M media/mojo/services/mojo_video_decoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/service_factory_impl.h View 2 chunks +7 lines, -8 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/mojo/services/test_manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
jrummell
Simple rename. All the formatting changes are due to git cl format.
4 years, 7 months ago (2016-05-14 00:31:25 UTC) #2
xhwang
On 2016/05/14 00:31:25, jrummell wrote: > Simple rename. All the formatting changes are due to ...
4 years, 7 months ago (2016-05-14 03:19:38 UTC) #3
sandersd (OOO until July 31)
https://chromiumcodereview.appspot.com/1977173002/diff/1/media/mojo/services/mojo_video_decoder.h File media/mojo/services/mojo_video_decoder.h (right): https://chromiumcodereview.appspot.com/1977173002/diff/1/media/mojo/services/mojo_video_decoder.h#newcode18 media/mojo/services/mojo_video_decoder.h:18: // A VideoDecoder that proxies to an mojom::VideoDecoder. Nit: ...
4 years, 7 months ago (2016-05-16 18:16:50 UTC) #5
jrummell
Updated. Kicked off the trybots to see if there are other places I missed. https://chromiumcodereview.appspot.com/1977173002/diff/1/media/mojo/services/mojo_video_decoder.h ...
4 years, 7 months ago (2016-05-16 21:34:41 UTC) #6
sandersd (OOO until July 31)
lgtm Not looking forward to merging with my VideoDecoderService CL, but it's safe to say ...
4 years, 7 months ago (2016-05-16 21:55:54 UTC) #7
jrummell
Adding OWNERS, this is just a namespace change. +dcheng@ for *.mojom files +piman@ for content/ ...
4 years, 7 months ago (2016-05-17 17:13:41 UTC) #9
piman
lgtm
4 years, 7 months ago (2016-05-17 17:26:49 UTC) #10
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-17 17:39:26 UTC) #11
dcheng
rs lgtm for mojom changes
4 years, 7 months ago (2016-05-17 17:59:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977173002/40001
4 years, 7 months ago (2016-05-17 18:03:01 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 18:10:08 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 18:12:02 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3
Cr-Commit-Position: refs/heads/master@{#394169}

Powered by Google App Engine
This is Rietveld 408576698