Issue 19771024: Parse content in the response for upload iff the upload is successfully done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19771024: Parse content in the response for upload iff the upload is successfully done. (Closed)

Created:
7 years, 5 months ago by hidehiko

Modified:
7 years, 5 months ago

Reviewers:
kinuko, kinaba

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Parse content in the response for upload iff the upload is successfully done. Uploading may fail due to confliction. In such a case, response may contain valid JSON data in the content of the response. However, here we expect only valid JSON data representing an uploaded file entry's metadata. This CL skips parsing JSON file, if an error is found. BUG=263330 TEST=Ran unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213385

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -15 lines)			Patch
M	chrome/browser/google_apis/base_requests.cc	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests_unittest.cc	View	6 chunks	+137 lines, -11 lines	0 comments	Download
A	chrome/test/data/drive/error.json	View	1 chunk	+16 lines, -0 lines	0 comments	Download