Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/browser/resources/history/history.js

Issue 19771022: REGRESSION: A history item should not be checked when the bookmark star is clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a comment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index d5a8ef8dc61b3f359252cab958d7ba8a53760ecb..b6eb19a779bfa122fdc7e3a75ef8a41805cac413 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -1772,6 +1772,9 @@ function entryBoxMousedown(event) {
* @param {!MouseEvent} event A click event.
*/
function entryBoxClick(event) {
+ // Do nothing if a bookmark star is clicked.
+ if (event.defaultPrevented)
+ return;
var tagName = event.target.tagName;
if (tagName == 'BUTTON' || tagName == 'INPUT' || tagName == 'A')
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698