Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: chrome/browser/resources/history/history.js

Issue 19771022: REGRESSION: A history item should not be checked when the bookmark star is clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a comment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="../uber/uber_utils.js"> 5 <include src="../uber/uber_utils.js">
6 6
7 /////////////////////////////////////////////////////////////////////////////// 7 ///////////////////////////////////////////////////////////////////////////////
8 // Globals: 8 // Globals:
9 /** @const */ var RESULTS_PER_PAGE = 150; 9 /** @const */ var RESULTS_PER_PAGE = 150;
10 10
(...skipping 1754 matching lines...) Expand 10 before | Expand all | Expand 10 after
1765 // Prevent text selection when shift-clicking to select multiple entries. 1765 // Prevent text selection when shift-clicking to select multiple entries.
1766 if (event.shiftKey) 1766 if (event.shiftKey)
1767 event.preventDefault(); 1767 event.preventDefault();
1768 } 1768 }
1769 1769
1770 /** 1770 /**
1771 * Handle click event for entryBox labels. 1771 * Handle click event for entryBox labels.
1772 * @param {!MouseEvent} event A click event. 1772 * @param {!MouseEvent} event A click event.
1773 */ 1773 */
1774 function entryBoxClick(event) { 1774 function entryBoxClick(event) {
1775 // Do nothing if a bookmark star is clicked.
1776 if (event.defaultPrevented)
1777 return;
1775 var tagName = event.target.tagName; 1778 var tagName = event.target.tagName;
1776 if (tagName == 'BUTTON' || tagName == 'INPUT' || tagName == 'A') 1779 if (tagName == 'BUTTON' || tagName == 'INPUT' || tagName == 'A')
1777 return; 1780 return;
1778 var checkbox = event.currentTarget.control; 1781 var checkbox = event.currentTarget.control;
1779 checkbox.checked = !checkbox.checked; 1782 checkbox.checked = !checkbox.checked;
1780 handleCheckboxStateChange(checkbox, event.shiftKey); 1783 handleCheckboxStateChange(checkbox, event.shiftKey);
1781 // We don't want to focus on the checkbox. 1784 // We don't want to focus on the checkbox.
1782 event.preventDefault(); 1785 event.preventDefault();
1783 } 1786 }
1784 1787
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1911 historyView.reload(); 1914 historyView.reload();
1912 } 1915 }
1913 1916
1914 // Add handlers to HTML elements. 1917 // Add handlers to HTML elements.
1915 document.addEventListener('DOMContentLoaded', load); 1918 document.addEventListener('DOMContentLoaded', load);
1916 1919
1917 // This event lets us enable and disable menu items before the menu is shown. 1920 // This event lets us enable and disable menu items before the menu is shown.
1918 document.addEventListener('canExecute', function(e) { 1921 document.addEventListener('canExecute', function(e) {
1919 e.canExecute = true; 1922 e.canExecute = true;
1920 }); 1923 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698