chrome/browser/notifications/sync_notifier/synced_notification.h - Issue 19771013: Adapting the UI to bring it closer to the spec, and fixing image fetching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/synced_notification.h

Issue 19771013: Adapting the UI to bring it closer to the spec, and fixing image fetching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adapting the UI: fix unit tests Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/sync_notifier/sync_notifier_test_utils.cc ('k') | chrome/browser/notifications/sync_notifier/synced_notification.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/synced_notification.h

diff --git a/chrome/browser/notifications/sync_notifier/synced_notification.h b/chrome/browser/notifications/sync_notifier/synced_notification.h

index fd3ee552cec80369f6e3c9d3919cd050bef287c2..a0d3b91dc4d757891e829d036ef0234fe44d4d76 100644

--- a/chrome/browser/notifications/sync_notifier/synced_notification.h

+++ b/chrome/browser/notifications/sync_notifier/synced_notification.h

@@ -52,6 +52,7 @@ class SyncedNotification : public NotificationBitmapFetcherDelegate {

std::string GetTitle() const;

std::string GetHeading() const;

std::string GetDescription() const;

+ std::string GetAnnotation() const;

std::string GetAppId() const;

std::string GetKey() const;

GURL GetOriginUrl() const;

@@ -67,6 +68,8 @@ class SyncedNotification : public NotificationBitmapFetcherDelegate {

std::string GetButtonTitle(unsigned int which_button) const;

GURL GetButtonIconUrl(unsigned int which_button) const;

GURL GetButtonUrl(unsigned int which_button) const;

+ GURL GetProfilePictureUrl(unsigned int which_url) const;

+ size_t GetProfilePictureCount() const;

size_t GetNotificationCount() const;

size_t GetButtonCount() const;

std::string GetContainedNotificationTitle(int index) const;

@@ -112,6 +115,7 @@ class SyncedNotification : public NotificationBitmapFetcherDelegate {

ScopedVector<NotificationBitmapFetcher> fetchers_;

int active_fetcher_count_;

gfx::Image app_icon_bitmap_;

+ gfx::Image sender_bitmap_;

gfx::Image image_bitmap_;

std::vector<gfx::Image> button_bitmaps_;