|
|
Created:
7 years, 5 months ago by petarj Modified:
7 years, 4 months ago Reviewers:
Mark Seaborn CC:
native-client-reviews_googlegroups.com Base URL:
http://git.chromium.org/native_client/src/native_client.git@master Visibility:
Public. |
Description[MIPS] Run toolchain build on a buildbot
Simple change to trigger building MIPS trusted toolchain on a buildbot.
BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275
TEST=
Patch Set 1 #Patch Set 2 : Rebase. #
Total comments: 6
Patch Set 3 : Update. #Messages
Total messages: 10 (0 generated)
This change has been tested at: https://codereview.chromium.org/21055008/ since it can not be tested directly. If the same system is set up at nacl-precise_64-newlib-x86_64-pnacl and linux-pnacl-x86_32-tests-mips, this should work. Additional question is whether we should first build nacl_sdk or chrome_sdk. We need both compiled and uploaded to commondatastorage.googleapis.com. PTAL.
> Additional question is whether we should first build nacl_sdk or chrome_sdk. > We need both compiled and uploaded to commondatastorage.googleapis.com. Please make this nacl_sdk for now. It will reduce resource usage, and we don't need chrome_sdk for building/testing (P)NaCl. https://codereview.chromium.org/19755007/diff/49001/buildbot/buildbot_selecto... File buildbot/buildbot_selector.py (right): https://codereview.chromium.org/19755007/diff/49001/buildbot/buildbot_selecto... buildbot/buildbot_selector.py:212: 'linux-pnacl-x86_32-tests-mips': Since you're changing this so that it isn't a PNaCl toolchain tester (yet), add an empty line before this so that the "# Pnacl toolchain testers" comment doesn't apply. https://codereview.chromium.org/19755007/diff/49001/buildbot/buildbot_selecto... buildbot/buildbot_selector.py:213: 'bash tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.debian.sh chrome_sdk', Line is >80 chars -- please fix that https://codereview.chromium.org/19755007/diff/49001/buildbot/buildbot_selecto... buildbot/buildbot_selector.py:214: #'bash buildbot/buildbot_pnacl_toolchain_tests.sh tc-test-bot mips', Remove the commented-out code
New patch set uploaded. Take a look. https://codereview.chromium.org/19755007/diff/49001/buildbot/buildbot_selecto... File buildbot/buildbot_selector.py (right): https://codereview.chromium.org/19755007/diff/49001/buildbot/buildbot_selecto... buildbot/buildbot_selector.py:212: 'linux-pnacl-x86_32-tests-mips': On 2013/08/07 17:18:34, Mark Seaborn wrote: > Since you're changing this so that it isn't a PNaCl toolchain tester (yet), add > an empty line before this so that the "# Pnacl toolchain testers" comment > doesn't apply. Done. https://codereview.chromium.org/19755007/diff/49001/buildbot/buildbot_selecto... buildbot/buildbot_selector.py:213: 'bash tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.debian.sh chrome_sdk', On 2013/08/07 17:18:34, Mark Seaborn wrote: > Line is >80 chars -- please fix that Done. https://codereview.chromium.org/19755007/diff/49001/buildbot/buildbot_selecto... buildbot/buildbot_selector.py:214: #'bash buildbot/buildbot_pnacl_toolchain_tests.sh tc-test-bot mips', On 2013/08/07 17:18:34, Mark Seaborn wrote: > Remove the commented-out code Done.
LGTM
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/19755007/76001
Failed to apply patch for buildbot/buildbot_selector.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file buildbot/buildbot_selector.py Hunk #1 FAILED at 209. 1 out of 1 hunk FAILED -- saving rejects to file buildbot/buildbot_selector.py.rej Patch: buildbot/buildbot_selector.py Index: buildbot/buildbot_selector.py diff --git a/buildbot/buildbot_selector.py b/buildbot/buildbot_selector.py index 7689b23a7f5f026cc88898e7c68182eab83ddba5..8b1d1000ff5210dcce2ab27ae80f33300fb680f8 100755 --- a/buildbot/buildbot_selector.py +++ b/buildbot/buildbot_selector.py @@ -209,8 +209,11 @@ BOT_ASSIGNMENT = { 'bash buildbot/buildbot_pnacl_toolchain_tests.sh tc-test-bot x86-32', 'linux-pnacl-x86_64-tests-arm': 'bash buildbot/buildbot_pnacl_toolchain_tests.sh tc-test-bot arm', + + # MIPS toolchain buildbot. 'linux-pnacl-x86_32-tests-mips': - 'bash buildbot/buildbot_pnacl_toolchain_tests.sh tc-test-bot mips', + 'bash tools/trusted_cross_toolchains/' + 'trusted-toolchain-creator.mipsel.debian.sh nacl_sdk', # Toolchain trybots. 'nacl-toolchain-lucid64-newlib':
On 2013/08/08 21:53:23, I haz the power (commit-bot) wrote: > Failed to apply patch for buildbot/buildbot_selector.py: > While running patch -p1 --forward --force --no-backup-if-mismatch; > patching file buildbot/buildbot_selector.py > Hunk #1 FAILED at 209. > 1 out of 1 hunk FAILED -- saving rejects to file > buildbot/buildbot_selector.py.rej > > Patch: buildbot/buildbot_selector.py > Index: buildbot/buildbot_selector.py > diff --git a/buildbot/buildbot_selector.py b/buildbot/buildbot_selector.py > index > 7689b23a7f5f026cc88898e7c68182eab83ddba5..8b1d1000ff5210dcce2ab27ae80f33300fb680f8 > 100755 > --- a/buildbot/buildbot_selector.py > +++ b/buildbot/buildbot_selector.py > @@ -209,8 +209,11 @@ BOT_ASSIGNMENT = { > 'bash buildbot/buildbot_pnacl_toolchain_tests.sh tc-test-bot x86-32', > 'linux-pnacl-x86_64-tests-arm': > 'bash buildbot/buildbot_pnacl_toolchain_tests.sh tc-test-bot arm', > + > + # MIPS toolchain buildbot. > 'linux-pnacl-x86_32-tests-mips': > - 'bash buildbot/buildbot_pnacl_toolchain_tests.sh tc-test-bot mips', > + 'bash tools/trusted_cross_toolchains/' > + 'trusted-toolchain-creator.mipsel.debian.sh nacl_sdk', > > # Toolchain trybots. > 'nacl-toolchain-lucid64-newlib': In a mysterious way, this change is already in.
On 8 August 2013 15:06, <petarj@mips.com> wrote: > In a mysterious way, this change is already in. > I noticed that and I thought it was strange. How did that happen? Did you commit it? I thought you don't have commit rights. Cheers, Mark -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/groups/opt_out.
On 2013/08/08 22:08:19, Mark Seaborn wrote: > I noticed that and I thought it was strange. How did that happen? Did you > commit it? I thought you don't have commit rights. > > Cheers, > Mark the Lord works in mysterious ways. :) I don't have commit rights, it may be somehow related to the restart of NaCl CQ. Regards, Petar
On 2013/08/08 22:15:54, petarj wrote: > On 2013/08/08 22:08:19, Mark Seaborn wrote: > > I noticed that and I thought it was strange. How did that happen? Did you > > commit it? I thought you don't have commit rights. > > > > Cheers, > > Mark > > the Lord works in mysterious ways. :) > I don't have commit rights, it may be somehow related to the restart of NaCl CQ. > > Regards, > Petar Closing. |