Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: runtime/vm/snapshot.h

Issue 1975423002: Check snapshots for feature compatibility. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/snapshot.h
diff --git a/runtime/vm/snapshot.h b/runtime/vm/snapshot.h
index 1c0fddb28aa5856cb24c76c509e83e569f50693a..b3c38d999b40734f9fb09abc7f4400f6a6c5b5ed 100644
--- a/runtime/vm/snapshot.h
+++ b/runtime/vm/snapshot.h
@@ -442,6 +442,7 @@ class SnapshotReader : public BaseReader {
// Read version number of snapshot and verify.
RawApiError* VerifyVersion();
+ RawApiError* VerifyFeatures();
// Helper functions for creating uninitialized versions
// of various object types. These are used when reading a
@@ -1020,6 +1021,7 @@ class SnapshotWriter : public BaseWriter {
// Write a version string for the snapshot.
void WriteVersion();
+ void WriteFeatures();
siva 2016/05/16 16:48:00 The comment is incorrect as it writes more than th
rmacnak 2016/05/16 20:59:56 I started out thinking the features string wouldn'
int32_t GetInstructionsId(RawInstructions* instructions, RawCode* code) {
return instructions_writer_->GetOffsetFor(instructions, code);
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/snapshot.cc » ('j') | runtime/vm/snapshot.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698