[NaCl SDK] Check that browser has support for NaCl/PNaCl/PPAPI.

[NaCl SDK] Check that browser has support for NaCl/PNaCl/PPAPI.

Demonstrate a canonical way to detect if the browser
has support for NaCl/PNaCl in the SDK examples.

Do the check before creating the embed tag, when the page
loads. If the browser does not have support, do not create
the embed and just update the status message.

If NaCl is disabled in about:plugins, then this will show
an error.  If NaCl is not enabled in about:flags, then
this will not show an error and continue loading.  The
embed tag will then either (a) be created for CWS apps
or (b) show a puzzle piece for the open web.

For PNaCl, the page will show an error and not attempt
to create an embed tag if either NaCl is disabled
in about:plugins, or PNaCl is disabled in about:flags.

BUG=243040
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213271

[binji, 2013-07-23 18:29:31]

lgtm

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
File native_client_sdk/src/examples/common.js (right):

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
native_client_sdk/src/examples/common.js:25: * @param {bool} is_release True if
this is a release build.
add @return doc

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
native_client_sdk/src/examples/common.js:46: * @param {string} tool The name of
the toolchain, e.g. "glibc", "newlib" etc.
add @return doc

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
native_client_sdk/src/examples/common.js:286: var is_release =
path.toLowerCase().indexOf('release') != -1;
nit: isRelease

[jvoung (off chromium), 2013-07-23 19:57:45]

Thanks!  Hmm it seemed like --register-pepper-plugin didn't add the mime type? 
Or maybe something was wrong with the way I tested.  Because of that, I also
disabled the check / return true for isHostToolchain().

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
File native_client_sdk/src/examples/common.js (right):

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
native_client_sdk/src/examples/common.js:25: * @param {bool} is_release True if
this is a release build.
On 2013/07/23 18:29:32, binji wrote:
> add @return doc

Done.

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
native_client_sdk/src/examples/common.js:46: * @param {string} tool The name of
the toolchain, e.g. "glibc", "newlib" etc.
On 2013/07/23 18:29:32, binji wrote:
> add @return doc

Done.

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
native_client_sdk/src/examples/common.js:286: var is_release =
path.toLowerCase().indexOf('release') != -1;
On 2013/07/23 18:29:32, binji wrote:
> nit: isRelease

Done.

Same code style for parameter names (above) too?

[binji, 2013-07-23 20:01:52]

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
File native_client_sdk/src/examples/common.js (right):

https://codereview.chromium.org/19751003/diff/9001/native_client_sdk/src/exam...
native_client_sdk/src/examples/common.js:286: var is_release =
path.toLowerCase().indexOf('release') != -1;
On 2013/07/23 19:57:45, jvoung (cr) wrote:
> On 2013/07/23 18:29:32, binji wrote:
> > nit: isRelease
> 
> Done.
> 
> Same code style for parameter names (above) too?

Yes, camelCase for all names in JavaScript.

[commit-bot: I haz the power, 2013-07-23 23:11:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@chromium.org/19751003/25001

[commit-bot: I haz the power, 2013-07-23 23:31:02]

Change committed as 213271