Issue 19744003: Change "Add Device" button to "Manage Devices" on ash tray bluetooth page.

Issue 19744003: Change "Add Device" button to "Manage Devices" on ash tray bluetooth page. (Closed)

Created:
7 years, 5 months ago by jennyz

Modified:
7 years, 5 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change "Add Device" button to "Manage Devices" on ash tray bluetooth page. BUG=175796 TBR=jamescook Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213292

Patch Set 1 #

Total comments: 3

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -21 lines)			Patch
M	ash/ash_strings.grd	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/system/bluetooth/tray_bluetooth.cc	View	4 chunks	+6 lines, -8 lines	0 comments	Download
M	ash/system/tray/system_tray_delegate.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/system/tray/test_system_tray_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/tray/test_system_tray_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	tools/metrics/actions/chromeactions.txt	View	2 chunks	+2 lines, -1 line	3 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jun Mukai

https://codereview.chromium.org/19744003/diff/1/tools/metrics/actions/chromeactions.txt File tools/metrics/actions/chromeactions.txt (right): https://codereview.chromium.org/19744003/diff/1/tools/metrics/actions/chromeactions.txt#newcode1508 tools/metrics/actions/chromeactions.txt:1508: 0x2c5584a8586dc1ab ShowBluetoothSettingsPage should be tab-separated in this file?

7 years, 5 months ago (2013-07-23 20:35:31 UTC) #2

jennyz

7 years, 5 months ago (2013-07-23 21:45:58 UTC) #3

Jun Mukai

lgtm https://codereview.chromium.org/19744003/diff/1/tools/metrics/actions/chromeactions.txt File tools/metrics/actions/chromeactions.txt (right): https://codereview.chromium.org/19744003/diff/1/tools/metrics/actions/chromeactions.txt#newcode1508 tools/metrics/actions/chromeactions.txt:1508: 0x2c5584a8586dc1ab ShowBluetoothSettingsPage On 2013/07/23 21:45:58, jennyz wrote: > ...

7 years, 5 months ago (2013-07-23 21:47:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/19744003/1

7 years, 5 months ago (2013-07-23 21:59:30 UTC) #5

Message was sent while issue was closed.

Change committed as 213292

Expand Messages | Collapse Messages