Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 19743002: Cross-origin access to Location::reload() should throw a SecurityError. (Closed)

Created:
7 years, 5 months ago by Mike West
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, do-not-use
Visibility:
Public.

Description

Cross-origin access to Location::reload() should throw a SecurityError. Location's 'reload' property is currently special-cased to be accessible cross-origin, but doesn't actually perform the requested action when executed. Instead, it dumps an error message to the console and returns early. Firefox's implementation throws an exception upon access of the property, and given that we've just changed various other Location properties to match this behavior. This also better aligns our behavior with the spec[1]. [1]: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#security-location BUG=17325 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154480

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
Mike West
Hi Adam! As briefly discussed in IRC, this patch slightly changes our behavior when dealing ...
7 years, 5 months ago (2013-07-18 07:33:31 UTC) #1
abarth-chromium
Aligning behavior with Firefox LGTM.
7 years, 5 months ago (2013-07-18 07:41:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/19743002/1
7 years, 5 months ago (2013-07-18 07:43:13 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 08:47:32 UTC) #4
Message was sent while issue was closed.
Change committed as 154480

Powered by Google App Engine
This is Rietveld 408576698