Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3394)

Unified Diff: chrome/browser/policy/cloud/cloud_policy_manager.h

Issue 19733003: Implement cloud policy invalidations using the invalidation service framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/cloud_policy_manager.h
diff --git a/chrome/browser/policy/cloud/cloud_policy_manager.h b/chrome/browser/policy/cloud/cloud_policy_manager.h
index 34be652e8e2a0fd8524a0a9f259c018900ee4ed0..6d63e874782eca6e97e9b5e8476e3ea54c398052 100644
--- a/chrome/browser/policy/cloud/cloud_policy_manager.h
+++ b/chrome/browser/policy/cloud/cloud_policy_manager.h
@@ -8,10 +8,12 @@
#include <string>
#include "base/basictypes.h"
+#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/prefs/pref_member.h"
#include "chrome/browser/policy/cloud/cloud_policy_constants.h"
#include "chrome/browser/policy/cloud/cloud_policy_core.h"
+#include "chrome/browser/policy/cloud/cloud_policy_invalidator.h"
#include "chrome/browser/policy/cloud/cloud_policy_store.h"
#include "chrome/browser/policy/configuration_policy_provider.h"
@@ -27,7 +29,8 @@ class PolicyBundle;
// functionality specific to user-level and device-level cloud policy, such as
// blocking on initial user policy fetch or device enrollment.
class CloudPolicyManager : public ConfigurationPolicyProvider,
- public CloudPolicyStore::Observer {
+ public CloudPolicyStore::Observer,
+ public CloudPolicyInvalidationHandler {
public:
CloudPolicyManager(const PolicyNamespaceKey& policy_ns_key,
CloudPolicyStore* cloud_policy_store);
@@ -36,6 +39,13 @@ class CloudPolicyManager : public ConfigurationPolicyProvider,
CloudPolicyCore* core() { return &core_; }
const CloudPolicyCore* core() const { return &core_; }
+ // Enables invalidations to the cloud policy. This method must only be
+ // called once.
+ // |initialize_invalidator| should initialize the invalidator when invoked.
+ // If the manager is ready to receive invalidations, it will be invoked
+ // immediately; otherwise, it will be invoked upon becoming ready.
+ void EnableInvalidations(const base::Closure& initialize_invalidator);
Mattias Nissler (ping if slow) 2013/08/28 14:20:40 This really shouldn't be here. The invalidator sho
+
// ConfigurationPolicyProvider:
virtual void Shutdown() OVERRIDE;
virtual bool IsInitializationComplete(PolicyDomain domain) const OVERRIDE;
@@ -45,11 +55,23 @@ class CloudPolicyManager : public ConfigurationPolicyProvider,
virtual void OnStoreLoaded(CloudPolicyStore* cloud_policy_store) OVERRIDE;
virtual void OnStoreError(CloudPolicyStore* cloud_policy_store) OVERRIDE;
+ // CloudPolicyInvalidationHandler:
+ virtual void SetInvalidationInfo(
+ int64 version,
+ const std::string& payload) OVERRIDE;
+ virtual void InvalidatePolicy() OVERRIDE;
+ virtual void OnInvalidatorStateChanged(bool invalidations_enabled) OVERRIDE;
+
protected:
// Check whether fully initialized and if so, publish policy by calling
// ConfigurationPolicyStore::UpdatePolicy().
void CheckAndPublishPolicy();
+ // Starts the policy refresh scheduler. This must be called instead of calling
+ // enabling the scheduler on core() directly so that invalidations are
+ // enabled correctly.
+ void StartRefreshScheduler();
+
// Called by CheckAndPublishPolicy() to create a bundle with the current
// policies.
virtual scoped_ptr<PolicyBundle> CreatePolicyBundle();
@@ -72,6 +94,10 @@ class CloudPolicyManager : public ConfigurationPolicyProvider,
// policy update notifications are deferred until after it completes.
bool waiting_for_policy_refresh_;
+ // Used to initialize the policy invalidator once the refresh scheduler
+ // starts.
+ base::Closure initialize_invalidator_;
+
DISALLOW_COPY_AND_ASSIGN(CloudPolicyManager);
};

Powered by Google App Engine
This is Rietveld 408576698