Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 19729007: Add SkImage->draw() call with src and dst rects. (Closed)

Created:
7 years, 5 months ago by arbesfeld
Modified:
7 years, 5 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add SkImage->draw() call with src and dst rects. Committed: http://code.google.com/p/skia/source/detail?r=10237 Committed: http://code.google.com/p/skia/source/detail?r=10274

Patch Set 1 #

Total comments: 11

Patch Set 2 : Add test, fix SkImage_Picture cropping. #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : Change virtual function name duplication, add implementation for SkImage_Codec #

Patch Set 5 : #

Patch Set 6 : Test paint = NULL path for SkPicture. #

Total comments: 3

Patch Set 7 : Fix 80/100 limits. #

Patch Set 8 : #

Patch Set 9 : #

Total comments: 2

Patch Set 10 : #

Total comments: 2

Patch Set 11 : #

Total comments: 3

Patch Set 12 : #

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -19 lines) Patch
M gm/image.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +49 lines, -19 lines 0 comments Download
M include/core/SkImage.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M src/image/SkImagePriv.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/SkImagePriv.cpp View 1 2 3 4 5 6 7 8 1 chunk +30 lines, -0 lines 0 comments Download
M src/image/SkImage_Base.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkImage_Codec.cpp View 1 2 3 4 5 6 2 chunks +12 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/image/SkImage_Picture.cpp View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
arbesfeld
PTAL. This patch is needed for https://codereview.chromium.org/19705006/
7 years, 5 months ago (2013-07-18 19:32:28 UTC) #1
Justin Novosad
https://codereview.chromium.org/19729007/diff/1/include/core/SkImage.h File include/core/SkImage.h (right): https://codereview.chromium.org/19729007/diff/1/include/core/SkImage.h#newcode85 include/core/SkImage.h:85: void draw(SkCanvas*, SkRect src, SkRect dst, const SkPaint*); Use ...
7 years, 5 months ago (2013-07-18 21:54:37 UTC) #2
arbesfeld
Any recommendation for what to call the class? NativeImageSkia is already taken... This is kind ...
7 years, 5 months ago (2013-07-18 22:39:45 UTC) #3
reed1
Primary comments: 1. clearly document the expected behavior in SkImage.h 2. write one or more ...
7 years, 5 months ago (2013-07-19 14:03:45 UTC) #4
arbesfeld
> https://codereview.chromium.org/19729007/diff/1/src/image/SkImagePriv.cpp#new... > src/image/SkImagePriv.cpp:147: int saveCount = canvas->getSaveCount(); > No need for this call. This ...
7 years, 5 months ago (2013-07-19 19:15:53 UTC) #5
reed1
https://codereview.chromium.org/19729007/diff/14001/include/core/SkImage.h File include/core/SkImage.h (right): https://codereview.chromium.org/19729007/diff/14001/include/core/SkImage.h#newcode89 include/core/SkImage.h:89: * filled with transparent black pixels. // See SkCanvas::drawBitmapRectToRect ...
7 years, 5 months ago (2013-07-19 19:32:29 UTC) #6
arbesfeld
I made those changes. The SkImage_Codec test is only configured for "mike's" machine (see drawJpeg ...
7 years, 5 months ago (2013-07-19 20:15:29 UTC) #7
reed1
lgtm w/ various nits about efficiency and exceeding 80/100 cols https://codereview.chromium.org/19729007/diff/25001/src/image/SkImagePriv.cpp File src/image/SkImagePriv.cpp (right): https://codereview.chromium.org/19729007/diff/25001/src/image/SkImagePriv.cpp#newcode152 ...
7 years, 5 months ago (2013-07-19 20:28:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/arbesfeld@chromium.org/19729007/36011
7 years, 5 months ago (2013-07-22 15:41:02 UTC) #9
commit-bot: I haz the power
Change committed as 10237
7 years, 5 months ago (2013-07-22 16:16:41 UTC) #10
reed1
https://chromiumcodereview.appspot.com/19729007/diff/36011/gm/image.cpp File gm/image.cpp (right): https://chromiumcodereview.appspot.com/19729007/diff/36011/gm/image.cpp#newcode43 gm/image.cpp:43: src->set(0, 0, image->width(), image->height()); Yikes! We are calling set() ...
7 years, 5 months ago (2013-07-22 17:04:12 UTC) #11
arbesfeld
On 2013/07/22 17:04:12, reed1 wrote: > https://chromiumcodereview.appspot.com/19729007/diff/36011/gm/image.cpp > File gm/image.cpp (right): > > https://chromiumcodereview.appspot.com/19729007/diff/36011/gm/image.cpp#newcode43 > ...
7 years, 5 months ago (2013-07-22 17:16:39 UTC) #12
reed1
If you need to rebaseline, that can/must happen *after* the code lands, and the bots ...
7 years, 5 months ago (2013-07-22 17:21:51 UTC) #13
arbesfeld
Okay, fixed.
7 years, 5 months ago (2013-07-22 17:38:42 UTC) #14
reed1
can you attach or email a screen-shot of the new gm? https://codereview.chromium.org/19729007/diff/50001/gm/image.cpp File gm/image.cpp (right): ...
7 years, 5 months ago (2013-07-22 18:19:49 UTC) #15
arbesfeld
That particular draw call (drawJpeg) has this comment: // TODO: Make this draw a file ...
7 years, 5 months ago (2013-07-22 18:40:29 UTC) #16
reed1
if we're not testing the jpeg function (due to non-portable image location), lets not modify ...
7 years, 5 months ago (2013-07-22 19:01:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/arbesfeld@chromium.org/19729007/26011
7 years, 5 months ago (2013-07-23 13:34:14 UTC) #18
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 15:52:20 UTC) #19
Message was sent while issue was closed.
Change committed as 10274

Powered by Google App Engine
This is Rietveld 408576698