Use URL hashes to switch tabs of chrome://translate-internals/

Use URL hashes to switch tabs of chrome://translate-internals/.

This CL enable to jump a tab directly by URL hash in chrome://translate-internals/.  For example, chrome://translate-internals/#detection-logs jumps to the detection-logs tab.  Likewise, when a user switch a tab, the URL's hash in the Omnibox will be changed to fit the current tab.

BUG=262870
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213375

[hajimehoshi, 2013-07-22 10:06:48]

Can you take a look?  Thank you in advance.

[Evan Stade, 2013-07-22 19:06:04]

please improve CL description to something that makes sense to someone sifting
through chrome's commit logs.

https://codereview.chromium.org/19724006/diff/1/chrome/browser/resources/tran...
File chrome/browser/resources/translate_internals/translate_internals.html
(right):

https://codereview.chromium.org/19724006/diff/1/chrome/browser/resources/tran...
chrome/browser/resources/translate_internals/translate_internals.html:35:
<tabpanel id="tabpanel-prefs">
why did you change this? seems like it just makes calculating the hash a little
harder.

https://codereview.chromium.org/19724006/diff/1/chrome/browser/resources/tran...
File chrome/browser/resources/translate_internals/translate_internals.js
(right):

https://codereview.chromium.org/19724006/diff/1/chrome/browser/resources/tran...
chrome/browser/resources/translate_internals/translate_internals.js:332: var
tabpanel = $('tabpanel-detection-logs');
no need to stick this in its own var

https://codereview.chromium.org/19724006/diff/1/chrome/browser/resources/tran...
chrome/browser/resources/translate_internals/translate_internals.js:353: var
tabpanel = $('tabpanel-error-logs');
no need to stick this in its own var

[hajimehoshi, 2013-07-23 03:56:19]

Thanks, and sorry for the lack of the description.

https://codereview.chromium.org/19724006/diff/1/chrome/browser/resources/tran...
File chrome/browser/resources/translate_internals/translate_internals.html
(right):

https://codereview.chromium.org/19724006/diff/1/chrome/browser/resources/tran...
chrome/browser/resources/translate_internals/translate_internals.html:35:
<tabpanel id="tabpanel-prefs">
The reason why I changed the ID is because I wanted to use #prefs to navigate
the tab, but #prefs conflicted the behavior of Chrome to jump the 'position' of
the tabpanel element.

On 2013/07/22 19:06:04, Evan Stade wrote:
> why did you change this? seems like it just makes calculating the hash a
little
> harder.

[Evan Stade, 2013-07-23 18:11:37]

the first line of the CL description is still very vague in the general context
of "all changes to Chrome". It needs to start with something like "in the
translation console".

otherwise lgtm

[commit-bot: I haz the power, 2013-07-24 01:54:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/19724006/1

[commit-bot: I haz the power, 2013-07-24 07:45:31]

Change committed as 213375