Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 19715002: Disabling failing/crashing androidwebview tests (Closed)

Created:
7 years, 5 months ago by Ramya
Modified:
7 years, 5 months ago
Reviewers:
joth, boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Disabling failing/crashing androidwebview tests BUG=261409, 261421 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212301

Patch Set 1 #

Total comments: 2

Patch Set 2 : New bug corresponding to the crashing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 3 chunks +18 lines, -6 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ramya
7 years, 5 months ago (2013-07-18 00:15:42 UTC) #1
Ramya
joth@ PTAL for lgtm
7 years, 5 months ago (2013-07-18 00:16:06 UTC) #2
boliu
https://codereview.chromium.org/19715002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java (right): https://codereview.chromium.org/19715002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java#newcode1606 android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:1606: public void testDatabaseEnabled() throws Throwable { Hmm, this is ...
7 years, 5 months ago (2013-07-18 00:19:55 UTC) #3
joth
+mnaganov In the linked log, I only see 3 tests failing, but you disabled 4? ...
7 years, 5 months ago (2013-07-18 00:20:19 UTC) #4
boliu
https://codereview.chromium.org/19715002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java (right): https://codereview.chromium.org/19715002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java#newcode1606 android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:1606: public void testDatabaseEnabled() throws Throwable { On 2013/07/18 00:19:55, ...
7 years, 5 months ago (2013-07-18 00:21:30 UTC) #5
Ramya
I filed crbug.com/261421 for the crashing test. http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/10997
7 years, 5 months ago (2013-07-18 00:29:24 UTC) #6
boliu
lgtm
7 years, 5 months ago (2013-07-18 00:30:20 UTC) #7
Ramya
joth@ PTAL for OWNERS lgtm
7 years, 5 months ago (2013-07-18 00:31:08 UTC) #8
joth
lgtm
7 years, 5 months ago (2013-07-18 00:50:13 UTC) #9
boliu
NOTRY+cq for you
7 years, 5 months ago (2013-07-18 06:00:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/19715002/4
7 years, 5 months ago (2013-07-18 06:01:36 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 09:08:09 UTC) #12
Message was sent while issue was closed.
Change committed as 212301

Powered by Google App Engine
This is Rietveld 408576698