Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 19705017: Create a new FileSystemOperationRunner for each FileAPIMessageFilter (Closed)

Created:
7 years, 5 months ago by kinuko
Modified:
7 years, 5 months ago
Reviewers:
Tom Sepez, tzik
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org, kinaba
Visibility:
Public.

Description

Create a new FileSystemOperationRunner for each FileAPIMessageFilter BUG=262918 TEST=FileAPIMessageFilter.{CloseChannelWithInflightRequest,MultipleFilters} Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -6 lines) Patch
M content/browser/fileapi/fileapi_message_filter.h View 3 chunks +6 lines, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter_unittest.cc View 3 chunks +72 lines, -0 lines 0 comments Download
M content/common/fileapi/file_system_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Can you review?
7 years, 5 months ago (2013-07-23 03:25:10 UTC) #1
tzik
lgtm
7 years, 5 months ago (2013-07-23 06:00:05 UTC) #2
kinuko
tsepez: can you take a look at content/common/fileapi/file_system_messages.h changes? The only change is adding EXPORT ...
7 years, 5 months ago (2013-07-23 06:52:02 UTC) #3
Tom Sepez
lgtm
7 years, 5 months ago (2013-07-23 18:11:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/19705017/1
7 years, 5 months ago (2013-07-24 02:41:43 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 07:44:44 UTC) #6
Message was sent while issue was closed.
Change committed as 213374

Powered by Google App Engine
This is Rietveld 408576698