chrome/browser/ui/browser_tab_contents.cc - Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_tab_contents.cc

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/browser/prerender/prerender_tab_helper.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_tab_contents.cc

diff --git a/chrome/browser/ui/browser_tab_contents.cc b/chrome/browser/ui/browser_tab_contents.cc

index 02c169168a455ae4914e8c7f352ba248aa7092d4..7104bb680a8b268359aced4c56892b2bbc28d186 100644

--- a/chrome/browser/ui/browser_tab_contents.cc

+++ b/chrome/browser/ui/browser_tab_contents.cc

@@ -142,7 +142,8 @@ void BrowserTabContents::AttachTabHelpers(WebContents* web_contents) {

PopupBlockerTabHelper::CreateForWebContents(web_contents);

}

PrefsTabHelper::CreateForWebContents(web_contents);

- prerender::PrerenderTabHelper::CreateForWebContents(web_contents);

+ prerender::PrerenderTabHelper::CreateForWebContentsWithPasswordManager(

+ web_contents, PasswordManager::FromWebContents(web_contents));

SadTabHelper::CreateForWebContents(web_contents);

safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);

SearchEngineTabHelper::CreateForWebContents(web_contents);

@@ -178,7 +179,8 @@ void BrowserTabContents::AttachTabHelpers(WebContents* web_contents) {

OneClickSigninHelper::CAN_OFFER_FOR_ALL,

std::string(),

NULL)) {

- OneClickSigninHelper::CreateForWebContents(web_contents);

+ OneClickSigninHelper::CreateForWebContentsWithPasswordManager(

+ web_contents, PasswordManager::FromWebContents(web_contents));

}

#endif