Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: content/renderer/render_view_impl.cc

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Callback Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index c5681bc26c0243c5d476c674ee41b212e160d555..ecb6ccfddcc6dbdc0437f6b09f8039e4a577d34a 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -65,7 +65,6 @@
#include "content/public/renderer/document_state.h"
#include "content/public/renderer/history_item_serialization.h"
#include "content/public/renderer/navigation_state.h"
-#include "content/public/renderer/password_form_conversion_utils.h"
#include "content/public/renderer/render_view_observer.h"
#include "content/public/renderer/render_view_visitor.h"
#include "content/renderer/accessibility/renderer_accessibility.h"
@@ -1840,10 +1839,6 @@ void RenderViewImpl::UpdateURL(WebFrame* frame) {
params.searchable_form_url = internal_data->searchable_form_url();
params.searchable_form_encoding = internal_data->searchable_form_encoding();
- const PasswordForm* password_form_data = document_state->password_form_data();
- if (password_form_data)
- params.password_form = *password_form_data;
-
params.gesture = navigation_gesture_;
navigation_gesture_ = NavigationGestureUnknown;
@@ -3240,7 +3235,8 @@ WebNavigationPolicy RenderViewImpl::decidePolicyForNavigation(
void RenderViewImpl::willSendSubmitEvent(WebKit::WebFrame* frame,
const WebKit::WebFormElement& form) {
- NOTREACHED();
+ FOR_EACH_OBSERVER(
+ RenderViewObserver, observers_, WillSendSubmitEvent(frame, form));
}
void RenderViewImpl::willSubmitForm(WebFrame* frame,
@@ -3488,23 +3484,6 @@ void RenderViewImpl::didStartProvisionalLoad(WebFrame* frame) {
navigation_gesture_ = WebUserGestureIndicator::isProcessingUserGesture() ?
NavigationGestureUser : NavigationGestureAuto;
- // If the navigation is not triggered by a user gesture, e.g. by some ajax
- // callback, then inherit the submitted password form from the previous
- // state. This fixes the no password save issue for ajax login, tracked in
- // [http://crbug/43219]. Note that there are still some sites that this
- // fails for because they use some element other than a submit button to
- // trigger submission.
- if (navigation_gesture_ == NavigationGestureAuto) {
- DocumentState* old_document_state = DocumentState::FromDataSource(
- frame->dataSource());
- const content::PasswordForm* old_password_form =
- old_document_state->password_form_data();
- if (old_password_form) {
- document_state->set_password_form_data(
- make_scoped_ptr(new content::PasswordForm(*old_password_form)));
- }
- }
-
// Make sure redirect tracking state is clear for the new load.
completed_client_redirect_src_ = Referrer();
} else if (frame->parent()->isLoading()) {

Powered by Google App Engine
This is Rietveld 408576698