chrome/browser/ui/sync/one_click_signin_helper_unittest.cc - Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Callback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/sync/one_click_signin_helper.cc ('K') | « chrome/browser/ui/sync/one_click_signin_helper.cc ('k') | chrome/chrome_common.gypi » ('j') | chrome/test/data/password/password_form.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

index a962faa4f737d469ae008ac03090f1c8fb158537..ae829be013d40b8c4bdbf78ff85ab0b1204c5a66 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

@@ -322,7 +322,7 @@ void OneClickSigninHelperTest::SubmitGAIAPassword(

password_form.origin = GURL("https://accounts.google.com");

password_form.signon_realm = "https://accounts.google.com";

password_form.password_value = UTF8ToUTF16("password");

- helper->OnFormSubmitted(password_form);

+ helper->PasswordSubmitted(password_form);

}

class OneClickSigninHelperIOTest : public OneClickSigninHelperTest {

@@ -647,7 +647,7 @@ TEST_F(OneClickSigninHelperTest, SigninFromWebstoreWithConfigSyncfirst) {

content::WebContents* contents = web_contents();

- OneClickSigninHelper::CreateForWebContents(contents);

+ OneClickSigninHelper::CreateForWebContentsWithPasswordManager(contents, NULL);

OneClickSigninHelper* helper =

OneClickSigninHelper::FromWebContents(contents);

helper->SetDoNotClearPendingEmailForTesting();