Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3157)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Callback Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.h
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.h b/chrome/browser/ui/sync/one_click_signin_helper.h
index 1a876fdf54ec84c32f8e6e612cd4912e4c150313..3daa95f1b976e7afe4a35cbeb0c3be25323a840f 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.h
+++ b/chrome/browser/ui/sync/one_click_signin_helper.h
@@ -8,6 +8,7 @@
#include <string>
#include "base/gtest_prod_util.h"
+#include "chrome/browser/password_manager/password_manager.h"
#include "chrome/browser/sync/profile_sync_service_observer.h"
#include "chrome/browser/ui/sync/sync_promo_ui.h"
#include "content/public/browser/navigation_controller.h"
@@ -76,6 +77,10 @@ class OneClickSigninHelper
CAN_OFFER_FOR_INTERSTITAL_ONLY
};
+ static void CreateForWebContentsWithPasswordManager(
+ content::WebContents* contents,
+ PasswordManager* password_manager);
+
virtual ~OneClickSigninHelper();
// Returns true if the one-click signin feature can be offered at this time.
@@ -162,7 +167,8 @@ class OneClickSigninHelper
// SAML-based accounts, but causes bug crbug.com/181163.
static const int kMaxNavigationsSince;
- explicit OneClickSigninHelper(content::WebContents* web_contents);
+ OneClickSigninHelper(content::WebContents* web_contents,
+ PasswordManager* password_manager);
// Returns true if the one-click signin feature can be offered at this time.
// It can be offered if the io_data is not in an incognito window and if the
@@ -204,11 +210,9 @@ class OneClickSigninHelper
// TestingProfile provides.
void SetDoNotClearPendingEmailForTesting();
- // Grab Gaia password if available.
- bool OnFormSubmitted(const content::PasswordForm& form);
+ void PasswordSubmitted(const content::PasswordForm& form);
Ilya Sherman 2013/07/27 01:09:48 nit: Docs?
Garrett Casto 2013/08/03 00:38:42 Done.
// content::WebContentsObserver overrides.
- virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void NavigateToPendingEntry(
const GURL& url,
content::NavigationController::ReloadType reload_type) OVERRIDE;
@@ -257,6 +261,9 @@ class OneClickSigninHelper
// pending e-mail.
bool do_not_clear_pending_email_;
+ // Callback for when passwords are submitted.
+ PasswordManager::PasswordSubmittedCallback password_callback_;
Ilya Sherman 2013/07/27 01:09:48 Why does this need to be stored as a class member
Garrett Casto 2013/08/03 00:38:42 Same as PrerenderTabHelper. Removed.
+
DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper);
};

Powered by Google App Engine
This is Rietveld 408576698