Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7593)

Unified Diff: chrome/browser/ui/browser_tab_contents.cc

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Callback Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_tab_contents.cc
diff --git a/chrome/browser/ui/browser_tab_contents.cc b/chrome/browser/ui/browser_tab_contents.cc
index e356025b08998824603f746e50d7799cca334c88..6db48ec43dfad4390687071cdb8e8548be5a38b9 100644
--- a/chrome/browser/ui/browser_tab_contents.cc
+++ b/chrome/browser/ui/browser_tab_contents.cc
@@ -142,7 +142,8 @@ void BrowserTabContents::AttachTabHelpers(WebContents* web_contents) {
PopupBlockerTabHelper::CreateForWebContents(web_contents);
}
PrefsTabHelper::CreateForWebContents(web_contents);
- prerender::PrerenderTabHelper::CreateForWebContents(web_contents);
+ prerender::PrerenderTabHelper::CreateForWebContentsWithPasswordManager(
+ web_contents, PasswordManager::FromWebContents(web_contents));
Ilya Sherman 2013/07/27 01:09:48 Hmm, why not just call PasswordManager::FromWebCon
Garrett Casto 2013/08/03 00:38:42 We could, but then there would be a hidden depende
Ilya Sherman 2013/08/06 09:34:11 Okay, fair enough :)
SadTabHelper::CreateForWebContents(web_contents);
safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);
SearchEngineTabHelper::CreateForWebContents(web_contents);
@@ -178,7 +179,8 @@ void BrowserTabContents::AttachTabHelpers(WebContents* web_contents) {
OneClickSigninHelper::CAN_OFFER_FOR_ALL,
std::string(),
NULL)) {
- OneClickSigninHelper::CreateForWebContents(web_contents);
+ OneClickSigninHelper::CreateForWebContentsWithPasswordManager(
+ web_contents, PasswordManager::FromWebContents(web_contents));
Ilya Sherman 2013/07/27 01:09:48 Ditto.
}
#endif

Powered by Google App Engine
This is Rietveld 408576698