Index: chrome/browser/password_manager/password_manager_unittest.cc |
diff --git a/chrome/browser/password_manager/password_manager_unittest.cc b/chrome/browser/password_manager/password_manager_unittest.cc |
index 45ab8518e7566111bc776f8839f1c377288453cf..3d19cfc4d5a39408e096f037085856ccd8771f11 100644 |
--- a/chrome/browser/password_manager/password_manager_unittest.cc |
+++ b/chrome/browser/password_manager/password_manager_unittest.cc |
@@ -85,6 +85,10 @@ class PasswordManagerTest : public ChromeRenderViewHostTestHarness { |
return PasswordManager::FromWebContents(web_contents()); |
} |
+ void OnPasswordFormSubmitted(const content::PasswordForm& form) { |
+ manager()->OnPasswordFormSubmitted(form); |
+ } |
+ |
scoped_refptr<MockPasswordStore> store_; |
MockPasswordManagerDelegate delegate_; // Owned by manager_. |
}; |
@@ -208,15 +212,8 @@ TEST_F(PasswordManagerTest, FormSeenThenLeftPage) { |
manager()->OnPasswordFormsParsed(observed); // The initial load. |
manager()->OnPasswordFormsRendered(observed); // The initial layout. |
- PasswordForm empty_form(form); |
- empty_form.username_value = string16(); |
- empty_form.password_value = string16(); |
- content::LoadCommittedDetails details; |
- content::FrameNavigateParams params; |
- params.password_form = empty_form; |
- manager()->DidNavigateAnyFrame(details, params); |
- |
- // No expected calls. |
+ // No message from the renderer that a password was submitted. No |
+ // expected calls. |
EXPECT_CALL(delegate_, AddSavePasswordInfoBarIfPermitted(_)).Times(0); |
observed.clear(); |
manager()->OnPasswordFormsParsed(observed); // The post-navigation load. |
@@ -238,14 +235,11 @@ TEST_F(PasswordManagerTest, FormSubmitAfterNavigateSubframe) { |
// Simulate navigating a sub-frame. |
content::LoadCommittedDetails details; |
- details.is_main_frame = false; |
content::FrameNavigateParams params; |
manager()->DidNavigateAnyFrame(details, params); |
- // Simulate navigating the real page. |
- details.is_main_frame = true; |
- params.password_form = form; |
- manager()->DidNavigateAnyFrame(details, params); |
+ // Simulate submitting the password. |
+ OnPasswordFormSubmitted(form); |
// Now the password manager waits for the navigation to complete. |
scoped_ptr<PasswordFormManager> form_to_save; |
@@ -289,7 +283,7 @@ TEST_F(PasswordManagerTest, FormSubmitWithFormOnPreviousPage) { |
content::LoadCommittedDetails details; |
details.is_main_frame = true; |
content::FrameNavigateParams params; |
- manager()->DidNavigateAnyFrame(details, params); |
+ manager()->DidNavigateMainFrame(details, params); |
// This page contains a form with the same markup, but on a different |
// URL. |
@@ -298,8 +292,7 @@ TEST_F(PasswordManagerTest, FormSubmitWithFormOnPreviousPage) { |
manager()->OnPasswordFormsRendered(observed); |
// Now submit this form |
- params.password_form = second_form; |
- manager()->DidNavigateAnyFrame(details, params); |
+ OnPasswordFormSubmitted(second_form); |
// Navigation after form submit. |
scoped_ptr<PasswordFormManager> form_to_save; |