Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: content/public/renderer/document_state.h

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/frame_navigate_params.h ('k') | content/public/renderer/document_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/document_state.h
diff --git a/content/public/renderer/document_state.h b/content/public/renderer/document_state.h
index 40a5f4241d787547cae23ae3fb4366f90503e55e..cd9fd585206107745a4800421fcf261b662f73d1 100644
--- a/content/public/renderer/document_state.h
+++ b/content/public/renderer/document_state.h
@@ -18,7 +18,6 @@
namespace content {
class NavigationState;
-struct PasswordForm;
// The RenderView stores an instance of this class in the "extra data" of each
// WebDataSource (see RenderView::DidCreateDataSource).
@@ -162,20 +161,6 @@ class CONTENT_EXPORT DocumentState
was_fetched_via_proxy_ = value;
}
- // If set, contains the PasswordForm that we believe triggered the current
- // navigation (there is some ambiguity in the case of javascript initiated
- // navigations). This information is used by the PasswordManager to determine
- // if the user should be prompted to save their password.
- //
- // Note that setting this field doesn't affect where the data is sent or what
- // origin we associate it with, only whether we prompt the user to save it.
- // That is, a false positive is a usability issue (e.g. may try to save a
- // mis-typed password) not a security issue.
- PasswordForm* password_form_data() const {
- return password_form_data_.get();
- }
- void set_password_form_data(scoped_ptr<PasswordForm> data);
-
void set_was_prefetcher(bool value) { was_prefetcher_ = value; }
bool was_prefetcher() const { return was_prefetcher_; }
@@ -220,8 +205,6 @@ class CONTENT_EXPORT DocumentState
net::HttpResponseInfo::ConnectionInfo connection_info_;
bool was_fetched_via_proxy_;
- scoped_ptr<PasswordForm> password_form_data_;
-
// A prefetcher is a page that contains link rel=prefetch elements.
bool was_prefetcher_;
bool was_referred_by_prefetcher_;
« no previous file with comments | « content/public/common/frame_navigate_params.h ('k') | content/public/renderer/document_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698