Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: chrome/browser/prerender/prerender_tab_helper.h

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_tab_helper.h
diff --git a/chrome/browser/prerender/prerender_tab_helper.h b/chrome/browser/prerender/prerender_tab_helper.h
index c48290efe872a3c5fc1294e62a600c91c3263d0c..4bfdd19919de31815088d6b5f1061284de00b999 100644
--- a/chrome/browser/prerender/prerender_tab_helper.h
+++ b/chrome/browser/prerender/prerender_tab_helper.h
@@ -12,6 +12,12 @@
#include "content/public/browser/web_contents_user_data.h"
#include "url/gurl.h"
+class PasswordManager;
+
+namespace content {
+struct PasswordForm;
+}
+
namespace predictors {
class LoggedInPredictorTable;
}
@@ -34,13 +40,14 @@ class PrerenderTabHelper
EVENT_MAINFRAME_COMMIT = 4,
EVENT_MAINFRAME_COMMIT_DOMAIN_LOGGED_IN = 5,
EVENT_LOGIN_ACTION_ADDED = 6,
- EVENT_LOGIN_ACTION_ADDED_MAINFRAME = 7,
- EVENT_LOGIN_ACTION_ADDED_MAINFRAME_PW_EMPTY = 8,
- EVENT_LOGIN_ACTION_ADDED_SUBFRAME = 9,
- EVENT_LOGIN_ACTION_ADDED_SUBFRAME_PW_EMPTY = 10,
+ EVENT_LOGIN_ACTION_ADDED_PW_EMPTY = 7,
EVENT_MAX_VALUE
};
+ static void CreateForWebContentsWithPasswordManager(
+ content::WebContents* web_contents,
+ PasswordManager* password_manager);
+
virtual ~PrerenderTabHelper();
// content::WebContentsObserver implementation.
@@ -63,15 +70,16 @@ class PrerenderTabHelper
const GURL& validated_url,
content::PageTransition transition_type,
content::RenderViewHost* render_view_host) OVERRIDE;
- virtual void DidNavigateAnyFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) OVERRIDE;
+
+ // Called when a password form has been submitted.
+ void PasswordSubmitted(const content::PasswordForm& form);
// Called when this prerendered WebContents has just been swapped in.
void PrerenderSwappedIn();
private:
- explicit PrerenderTabHelper(content::WebContents* web_contents);
+ PrerenderTabHelper(content::WebContents* web_contents,
+ PasswordManager* password_manager);
friend class content::WebContentsUserData<PrerenderTabHelper>;
void RecordEvent(Event event) const;
« no previous file with comments | « chrome/browser/password_manager/password_manager_unittest.cc ('k') | chrome/browser/prerender/prerender_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698