chrome/test/data/password/password_form.html - Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/password_form.html

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Callback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/sync/one_click_signin_helper.cc ('K') | « chrome/test/data/password/multi_frames.html ('k') | chrome/test/data/password/password_xhr_done.html » ('j') | components/autofill/content/renderer/password_autofill_agent.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3 <form action="done.html" onsubmit="return true;" id="testform">

	4 <input type="text" id="username_field" name="username_field">

	5 <input type="password" id="password_field" name="password_field">

	6 <input type="submit" id="input_submit_button" name="input_submit_button">
	Ilya Sherman 2013/07/27 01:09:48 nit: Do you really need ids for the <input>s? Doe nit: Do you really need ids for the <input>s? Doesn't seem like they ought to matter. Garrett Casto 2013/08/03 00:38:42 I use GetElementById() in the test. Show quoted text On 2013/07/27 01:09:48, Ilya Sherman wrote: > nit: Do you really need ids for the <input>s? Doesn't seem like they ought to > matter. I use GetElementById() in the test.
	7 </form>

	8

	9 <button id="submit_button" name="submit_button"

	10 onclick="document.getElementById('testform').submit()">

	11 Submit!

	12 </button>

	13

	14 </body>

	15 </html>

OLD	NEW