Pepper: Add routing ID information to Connection.

Pepper: Add routing ID information to Connection.

To support in-process plugins, ResourceCall messages from the renderer to the
browser will need to provide routing ID information for receiving a reply. We
add a boolean for "in_process" as well so the plugin need only send the extra
information when the plugin is running in-process.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213223

[yzshen1, 2013-07-23 17:44:01]

https://codereview.chromium.org/19704009/diff/1/content/renderer/pepper/peppe...
File content/renderer/pepper/pepper_in_process_router.cc (right):

https://codereview.chromium.org/19704009/diff/1/content/renderer/pepper/peppe...
content/renderer/pepper/pepper_in_process_router.cc:62: PP_Instance instance) {
GetRoutingIDForWidget() doesn't always return the same routing ID for an
instance:
"""
This will take into account the current Flash fullscreen state, so if there is a
Flash fullscreen instance active, this will return the routing ID of the
fullscreen widget.
"""

I think you always want the routing ID of the render view hosting the plugin,
instead of the fullscreen render widget, right?

https://codereview.chromium.org/19704009/diff/1/ppapi/proxy/connection.h
File ppapi/proxy/connection.h (right):

https://codereview.chromium.org/19704009/diff/1/ppapi/proxy/connection.h#newc...
ppapi/proxy/connection.h:41: int routing_id;
- Please add comments about why we need this |routing_id|, and which sender
(browser_sender, right?) it is used with.

- [optional] I think maybe a more specific name such as
browser_sender_routing_id is better.

[teravest, 2013-07-23 17:59:50]

https://codereview.chromium.org/19704009/diff/1/content/renderer/pepper/peppe...
File content/renderer/pepper/pepper_in_process_router.cc (right):

https://codereview.chromium.org/19704009/diff/1/content/renderer/pepper/peppe...
content/renderer/pepper/pepper_in_process_router.cc:62: PP_Instance instance) {
On 2013/07/23 17:44:01, yzshen1 wrote:
> GetRoutingIDForWidget() doesn't always return the same routing ID for an
> instance:
> """
> This will take into account the current Flash fullscreen state, so if there is
a
> Flash fullscreen instance active, this will return the routing ID of the
> fullscreen widget.
> """
> 
> I think you always want the routing ID of the render view hosting the plugin,
> instead of the fullscreen render widget, right?

Changed to get the routing ID from the render view.

https://codereview.chromium.org/19704009/diff/1/ppapi/proxy/connection.h
File ppapi/proxy/connection.h (right):

https://codereview.chromium.org/19704009/diff/1/ppapi/proxy/connection.h#newc...
ppapi/proxy/connection.h:41: int routing_id;
On 2013/07/23 17:44:01, yzshen1 wrote:
> - Please add comments about why we need this |routing_id|, and which sender
> (browser_sender, right?) it is used with.
> 
> - [optional] I think maybe a more specific name such as
> browser_sender_routing_id is better.

Done.

[yzshen1, 2013-07-23 18:02:39]

lgtm

[commit-bot: I haz the power, 2013-07-23 18:06:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/19704009/11001

[commit-bot: I haz the power, 2013-07-23 21:19:38]

Change committed as 213223