Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 19702003: Use GetActiveDesktop instead of hardcoding HOST_DESKTOP_TYPE_NATIVE in tests. (Closed)

Created:
7 years, 5 months ago by gab
Modified:
7 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Use GetActiveDesktop instead of hardcoding HOST_DESKTOP_TYPE_NATIVE in tests. BUG=179830 TEST=Fixes StartupBrowserCreatorTest.OpenURLsPopup for Ash browser tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gab
Scott, PTAL, thanks! Feel free to CQ.
7 years, 5 months ago (2013-07-23 22:28:17 UTC) #1
sky
LGTM
7 years, 5 months ago (2013-07-23 22:52:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/19702003/1
7 years, 5 months ago (2013-07-23 22:55:19 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 07:44:04 UTC) #4
Message was sent while issue was closed.
Change committed as 213373

Powered by Google App Engine
This is Rietveld 408576698