Add new metrics descriptions.

Add new metrics descriptions.

BUG=247371
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213874

[Alexei Svitkine (slow), 2013-07-23 17:44:36]

I don't see these histograms when doing a code search. Are you adding them in a
concurrent CL? If so, please include this change in that CL so that the two are
landed together.

If not, please point at the CL where these were added.

[Denis Kuznetsov (DE-MUC), 2013-07-23 19:36:53]

On 2013/07/23 17:44:36, Alexei Svitkine wrote:
> I don't see these histograms when doing a code search. Are you adding them in
a
> concurrent CL? If so, please include this change in that CL so that the two
are
> landed together.
> 
> If not, please point at the CL where these were added.

They are added from chromeos, concurrent CL is here:
https://gerrit.chromium.org/gerrit/#/c/63079/1

[Alexei Svitkine (slow), 2013-07-23 19:49:04]

https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:9196: <histogram
name="Platform.DiskUsage.HighUserCount.Cache_Avg" units="KB">
You can make these less verbose by using a fieldtrial construct in the XML file
to give all of these histograms a common prefix. See the example at the top of
histograms.xml.

[Alexei Svitkine (slow), 2013-07-23 19:50:42]

On 2013/07/23 19:49:04, Alexei Svitkine wrote:
>
https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histogra...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histogra...
> tools/metrics/histograms/histograms.xml:9196: <histogram
> name="Platform.DiskUsage.HighUserCount.Cache_Avg" units="KB">
> You can make these less verbose by using a fieldtrial construct in the XML
file
> to give all of these histograms a common prefix. See the example at the top of
> histograms.xml.

A good example is ProfilePictureDownload. Note that it defines a custom
separator as "." rather than the default of _.

[Denis Kuznetsov (DE-MUC), 2013-07-24 14:13:41]

https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:9196: <histogram
name="Platform.DiskUsage.HighUserCount.Cache_Avg" units="KB">
On 2013/07/23 19:49:04, Alexei Svitkine wrote:
> You can make these less verbose by using a fieldtrial construct in the XML
file
> to give all of these histograms a common prefix. See the example at the top of
> histograms.xml.

I could not find ProfilePictureDownload using chrome code search, but I've used
the prefix.

[Alexei Svitkine (slow), 2013-07-24 18:55:16]

https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:21722: <group name="Cache_Avg"/>
Please add a label="..." attribute explaining these.

https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:21729: <affected-histogram
name="Platform.DiskUsage.1User"/>
I'm not sure if you already submitted the other CL, but if you have the
flexibility of changing these on the CrOS CL, it would be better to re-order the
parts of the name, so that 1User, 2Users, 3Users, etc are actual "group" entries
in this model (i.e. suffixes), so that you can have proper descriptions for
Cache vs. Downloads, etc.

Then, your histograms would look like:

Platform.DiskUsage.Cache_Max.2Users

[Denis Kuznetsov (DE-MUC), 2013-07-25 17:04:36]

https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:21729: <affected-histogram
name="Platform.DiskUsage.1User"/>
On 2013/07/24 18:55:17, Alexei Svitkine wrote:
> I'm not sure if you already submitted the other CL, but if you have the
> flexibility of changing these on the CrOS CL, it would be better to re-order
the
> parts of the name, so that 1User, 2Users, 3Users, etc are actual "group"
entries
> in this model (i.e. suffixes), so that you can have proper descriptions for
> Cache vs. Downloads, etc.
> 
> Then, your histograms would look like:
> 
> Platform.DiskUsage.Cache_Max.2Users

Done.

[Alexei Svitkine (slow), 2013-07-25 18:28:42]

lgtm with a comment, thanks!

https://codereview.chromium.org/19700006/diff/16001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/19700006/diff/16001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:21715: <group name="1User"/>
Nit: Add a label="" entry to each of these explaining this case.

[Alexei Svitkine (slow), 2013-07-25 18:29:14]

Also, please change the title/description of the CL to be more descriptive.
Thanks!

[commit-bot: I haz the power, 2013-07-26 12:58:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/19700006/22001

[commit-bot: I haz the power, 2013-07-26 13:02:41]

Change committed as 213874