Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 19700006: Add new metrics descriptions. (Closed)

Created:
7 years, 5 months ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add new metrics descriptions. BUG=247371 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213874

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use fieldtrial for minimizing redundancy #

Patch Set 3 : Change wording a bit #

Total comments: 3

Patch Set 4 : Change order of dir/user count groupping #

Patch Set 5 : Change name of fieldtrial #

Total comments: 1

Patch Set 6 : Fix final nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 2 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Denis Kuznetsov (DE-MUC)
7 years, 5 months ago (2013-07-23 16:31:40 UTC) #1
Alexei Svitkine (slow)
I don't see these histograms when doing a code search. Are you adding them in ...
7 years, 5 months ago (2013-07-23 17:44:36 UTC) #2
Denis Kuznetsov (DE-MUC)
On 2013/07/23 17:44:36, Alexei Svitkine wrote: > I don't see these histograms when doing a ...
7 years, 5 months ago (2013-07-23 19:36:53 UTC) #3
Alexei Svitkine (slow)
https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histograms/histograms.xml#newcode9196 tools/metrics/histograms/histograms.xml:9196: <histogram name="Platform.DiskUsage.HighUserCount.Cache_Avg" units="KB"> You can make these less verbose ...
7 years, 5 months ago (2013-07-23 19:49:04 UTC) #4
Alexei Svitkine (slow)
On 2013/07/23 19:49:04, Alexei Svitkine wrote: > https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (right): > > https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histograms/histograms.xml#newcode9196 ...
7 years, 5 months ago (2013-07-23 19:50:42 UTC) #5
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://chromiumcodereview.appspot.com/19700006/diff/1/tools/metrics/histograms/histograms.xml#newcode9196 tools/metrics/histograms/histograms.xml:9196: <histogram name="Platform.DiskUsage.HighUserCount.Cache_Avg" units="KB"> On 2013/07/23 19:49:04, Alexei Svitkine wrote: ...
7 years, 5 months ago (2013-07-24 14:13:41 UTC) #6
Alexei Svitkine (slow)
https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/histograms.xml#newcode21722 tools/metrics/histograms/histograms.xml:21722: <group name="Cache_Avg"/> Please add a label="..." attribute explaining these. ...
7 years, 5 months ago (2013-07-24 18:55:16 UTC) #7
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/19700006/diff/11001/tools/metrics/histograms/histograms.xml#newcode21729 tools/metrics/histograms/histograms.xml:21729: <affected-histogram name="Platform.DiskUsage.1User"/> On 2013/07/24 18:55:17, Alexei Svitkine wrote: > ...
7 years, 5 months ago (2013-07-25 17:04:36 UTC) #8
Alexei Svitkine (slow)
lgtm with a comment, thanks! https://codereview.chromium.org/19700006/diff/16001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/19700006/diff/16001/tools/metrics/histograms/histograms.xml#newcode21715 tools/metrics/histograms/histograms.xml:21715: <group name="1User"/> Nit: Add ...
7 years, 5 months ago (2013-07-25 18:28:42 UTC) #9
Alexei Svitkine (slow)
Also, please change the title/description of the CL to be more descriptive. Thanks!
7 years, 5 months ago (2013-07-25 18:29:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/19700006/22001
7 years, 5 months ago (2013-07-26 12:58:43 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 13:02:41 UTC) #12
Message was sent while issue was closed.
Change committed as 213874

Powered by Google App Engine
This is Rietveld 408576698