Crash on message center settings change fixed

Crash on message center settings change fixed

The default profile was being used to set which applications can show
notifications. This has been changed to use the last used profile allowed by 
policy. In case the profile happens to be deleted after the message center 
settings controller is created, we just fail silently. Since full-fledged 
multi-profile support will be rolling out in the near future, this is a 
temporary fix to prevent chrome from crashing.

BUG=263193
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213326

[dewittj, 2013-07-22 23:03:12]

https://codereview.chromium.org/19699014/diff/2001/chrome/browser/notificatio...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/19699014/diff/2001/chrome/browser/notificatio...
chrome/browser/notifications/message_center_settings_controller.cc:90: if
(!profile_)
Can we call GetLastUsedProfileAllowedByPolicy here instead of in the
constructor?

[sidharthms, 2013-07-23 00:50:07]

https://codereview.chromium.org/19699014/diff/2001/chrome/browser/notificatio...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/19699014/diff/2001/chrome/browser/notificatio...
chrome/browser/notifications/message_center_settings_controller.cc:90: if
(!profile_)
On 2013/07/22 23:03:12, dewittj wrote:
> Can we call GetLastUsedProfileAllowedByPolicy here instead of in the
> constructor?

Done.

[dewittj, 2013-07-23 01:04:03]

https://codereview.chromium.org/19699014/diff/13002/chrome/browser/notificati...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/19699014/diff/13002/chrome/browser/notificati...
chrome/browser/notifications/message_center_settings_controller.cc:69:
content::Source<Profile>(profile_));
this now listens for profile destroyed (NULL).  Need to have a different
strategy here, either AllSources, or update the source when you choose the
profile below.

[sidharthms, 2013-07-23 01:29:25]

https://codereview.chromium.org/19699014/diff/13002/chrome/browser/notificati...
File chrome/browser/notifications/message_center_settings_controller.cc (right):

https://codereview.chromium.org/19699014/diff/13002/chrome/browser/notificati...
chrome/browser/notifications/message_center_settings_controller.cc:69:
content::Source<Profile>(profile_));
On 2013/07/23 01:04:03, dewittj wrote:
> this now listens for profile destroyed (NULL).  Need to have a different
> strategy here, either AllSources, or update the source when you choose the
> profile below.

Done. Sorry about that.

[dewittj, 2013-07-23 01:35:51]

lgtm

[commit-bot: I haz the power, 2013-07-23 05:54:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sidharthms@chromium.org/19699014/18001

[commit-bot: I haz the power, 2013-07-23 07:07:35]

Retried try job too often on mac_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-07-24 01:40:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sidharthms@chromium.org/19699014/18001

[commit-bot: I haz the power, 2013-07-24 02:53:41]

Change committed as 213326