chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 19699007: Ensure we don't crash if user navigates back from NTP to Chrome sign-in page before it has fully lo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 19699007: Ensure we don't crash if user navigates back from NTP to Chrome sign-in page before it has fully lo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing indent. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

index 720836f61618f515aa36e1e1adb76dcd65d3cb51..7ad5e8660e14518f167849a606057f4516261494 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

@@ -482,8 +482,8 @@ void SafeBrowsingBlockingPage::OnDontProceed() {

if (navigation_entry_index_to_remove_ != -1 &&

navigation_entry_index_to_remove_ != last_committed_index &&

!web_contents_->IsBeingDestroyed()) {

- web_contents_->GetController().RemoveEntryAtIndex(

- navigation_entry_index_to_remove_);

+ CHECK(web_contents_->GetController().RemoveEntryAtIndex(

+ navigation_entry_index_to_remove_));

navigation_entry_index_to_remove_ = -1;

}

« no previous file with comments | « no previous file | chrome/browser/signin/signin_browsertest.cc » ('j') | no next file with comments »