Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 19695015: Re-land Implement MIDIOutput.send() (Closed)

Created:
7 years, 5 months ago by Chris Rogers
Modified:
7 years, 5 months ago
Reviewers:
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix windows build - move MIDIOutput destructor to be non-inline #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -29 lines) Patch
M LayoutTests/webmidi/requestmidiaccess.html View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.h View 3 chunks +6 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 6 chunks +30 lines, -8 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.h View 1 1 chunk +14 lines, -5 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.cpp View 1 1 chunk +50 lines, -10 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/MIDIClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebMIDIPermissionRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/19695015/2001
7 years, 5 months ago (2013-07-24 19:23:20 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=18300
7 years, 5 months ago (2013-07-24 20:45:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/19695015/25001
7 years, 5 months ago (2013-07-24 22:16:19 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 23:34:34 UTC) #4
Message was sent while issue was closed.
Change committed as 154858

Powered by Google App Engine
This is Rietveld 408576698