Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 19695014: linux: Avoid leak in PlatformFontPangoTest.FamilyList. (Closed)

Created:
7 years, 5 months ago by Daniel Erat
Modified:
7 years, 5 months ago
CC:
chromium-reviews, derat+watch_chromium.org
Visibility:
Public.

Description

linux: Avoid leak in PlatformFontPangoTest.FamilyList. Call FcFini() at the end of the test to prevent FontConfig from leaking memory. BUG=114750 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213996

Patch Set 1 #

Patch Set 2 : add fontconfig dependency #

Patch Set 3 : call FcInit #

Patch Set 4 : remove FcInit call #

Patch Set 5 : free fontconfig resources from pango and cairo #

Patch Set 6 : make pangocairo dependency pull in pangoft2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -27 lines) Patch
M build/linux/system.gyp View 1 2 3 4 5 1 chunk +6 lines, -6 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 2 3 4 1 chunk +0 lines, -21 lines 0 comments Download
M ui/gfx/platform_font_pango_unittest.cc View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Daniel Erat
free fontconfig resources from pango and cairo
7 years, 5 months ago (2013-07-24 22:23:45 UTC) #1
Daniel Erat
7 years, 5 months ago (2013-07-24 23:22:43 UTC) #2
behdad_google
lgtm
7 years, 5 months ago (2013-07-25 19:15:14 UTC) #3
Daniel Erat
TBR sky for approval
7 years, 5 months ago (2013-07-25 19:17:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/19695014/12001
7 years, 5 months ago (2013-07-25 19:29:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/19695014/12001
7 years, 5 months ago (2013-07-26 00:54:25 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-26 03:40:23 UTC) #7
Daniel Erat
Hmm. The pango_fc_* functions come from pangoft2. build/linux/system.gyp defines pangocairo, freetype2, and fontconfig targets. I ...
7 years, 5 months ago (2013-07-26 15:59:20 UTC) #8
behdad_google
On 2013/07/26 15:59:20, Daniel Erat wrote: > Hmm. The pango_fc_* functions come from pangoft2. build/linux/system.gyp ...
7 years, 5 months ago (2013-07-26 16:02:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/19695014/48001
7 years, 5 months ago (2013-07-26 16:33:32 UTC) #10
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 22:54:09 UTC) #11
Message was sent while issue was closed.
Change committed as 213996

Powered by Google App Engine
This is Rietveld 408576698