Issue 19693018: Do not increase volume when user press Volume Up Button to unmute the audio output.

Issue 19693018: Do not increase volume when user press Volume Up Button to unmute the audio output. (Closed)

Created:
7 years, 5 months ago by jennyz

Modified:
7 years, 5 months ago

Reviewers:
James Cook, Daniel Erat

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Do not increase volume when user press Volume Up Button to unmute the audio output. BUG=263424 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213321

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ui/ash/volume_controller_chromeos.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

James Cook

to derat -> what is the desired behavior for volume up after mute?

7 years, 5 months ago (2013-07-23 23:32:07 UTC) #2

jennyz

On 2013/07/23 23:32:07, James Cook (Chromium) wrote: > to derat -> what is the desired ...

7 years, 5 months ago (2013-07-23 23:34:36 UTC) #3

Daniel Erat

Just noticed that volume_controller_browsertest_chromeos.cc exists! Please add a test there to make sure that this ...

7 years, 5 months ago (2013-07-23 23:40:20 UTC) #5

jennyz

On 2013/07/23 23:40:20, Daniel Erat wrote: > Just noticed that volume_controller_browsertest_chromeos.cc exists! Please add a ...

7 years, 5 months ago (2013-07-23 23:50:18 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/19693018/1

7 years, 5 months ago (2013-07-23 23:55:00 UTC) #7

Message was sent while issue was closed.

Change committed as 213321